Skip to content

Activity cards#5672

Closed
htmlboy wants to merge 1 commit intomasterfrom
feature/activity-cards
Closed

Activity cards#5672
htmlboy wants to merge 1 commit intomasterfrom
feature/activity-cards

Conversation

@htmlboy
Copy link
Copy Markdown
Contributor

@htmlboy htmlboy commented Jan 29, 2020

🎩 What? Why?

Design model: simplified activity cards for the home page.

📌 Related Issues

  • Related to #?
  • Fixes #?

📋 Subtasks

  • Add CHANGELOG entry
  • Add documentation regarding the feature
  • Add/modify seeds
  • Add tests
  • Another subtask

📷 Screenshots (optional)

Screenshot 2020-01-29 at 10 38 15

@tramuntanal
Copy link
Copy Markdown
Contributor

Hi @htmlboy we've been assigned the task of helping you with the back-end part of this task.
What do you need exactly?

@htmlboy
Copy link
Copy Markdown
Contributor Author

htmlboy commented Feb 3, 2020

@tramuntanal Hi, thanks for the help. As commented with @carolromero @arnaumonty we should reduce the description of these activity cards to 2 lines (probably around 100 chars?) and add an ellipsis afterwards in order to prevent the cards from taking too much vertical space. Thanks!

@Leusev
Copy link
Copy Markdown
Contributor

Leusev commented Feb 12, 2020

Hi @htmlboy
I'm new assigned back-end dev for this issue.
Checking it, I realised that already was been applying a reduction to 100 chars in activity card's description, so I tried if whether possible to adjust two lines limitation through css. Trying it, I realised that the two line adjustment varies depending on device: mobile -> automatically changes to three line adjustment as well as tablet.
So this leads me to one question, does it is necessary to control the two lines adjustment with all devices or only in desktop/laptop?
Thanks in advance

@htmlboy
Copy link
Copy Markdown
Contributor Author

htmlboy commented Feb 12, 2020

@Leusev Hi, I think focusing on Desktop is ok in this case; in a previous version, the cards were not applying any limitation (or perhaps the type of cards shown) and everything was quite unbalanced. Apart from the text length, there's a design proposal in this branch for these cards.

Thanks!

@Leusev
Copy link
Copy Markdown
Contributor

Leusev commented Feb 13, 2020

Hi @htmlboy
I'll reduce default 100 chars lenght to 80, assuring that in desktop devices, the activity cards will only occupy the asked two lines.
About your design proposal for these cards, what should I do with it? I mean, should I apply the new design proposal to the last activity card?
Thanks in advance,

@htmlboy
Copy link
Copy Markdown
Contributor Author

htmlboy commented Feb 13, 2020

@Leusev Hi, yes, I think it was the idea, but @carolromero or @arnaumonty will be able to confirm it :.-)

80 chars sounds good!

@carolromero
Copy link
Copy Markdown
Member

Hi @Leusev, yes, 80 chars are ok, thanks!

@Leusev Leusev mentioned this pull request Feb 14, 2020
5 tasks
@Leusev
Copy link
Copy Markdown
Contributor

Leusev commented Feb 17, 2020

Hello @carolromero ,
I had a question about @htmlboy design proposal for "last activity cards"
It should be applied the new design proposal to the current last activity card?
Thanks in advance

@carolromero
Copy link
Copy Markdown
Member

Hi @Leusev, yep, that's correct! We get rid of the current design in favor of this other, thanks!

@Leusev
Copy link
Copy Markdown
Contributor

Leusev commented Feb 17, 2020

Hello @htmlboy
due to some issue, I've had made a PR "Decidim shorten Last Activity Cards's description #5742" with backend changes about shorten last activity cards length
I assigned a reviewer too, so it should be available shortly
Greetings

@Leusev
Copy link
Copy Markdown
Contributor

Leusev commented Feb 19, 2020

Hi @htmlboy
the issue #5742 has already been reviewed and merged into master
Greetings

@ivan-mr
Copy link
Copy Markdown
Contributor

ivan-mr commented Mar 5, 2020

Hello @htmlboy.
I found a problem implementing this redesign on the activity card.
I can't insert the creation date of activity data inside the div class="author-data" because inside this div only exists information about the author, not the activity.
Maybe it is better to put the creation date of the activity outside the class="author-data" div and make this div float or displayed as inline-block to show all the info in a one-line format
Captura de pantalla de 2020-03-05 18-15-57
In this image you can see creation date of the activity is inside the div class="author-data" and inside the class="author-data__extra" div, but this last div is for information about the author not the activity

@htmlboy
Copy link
Copy Markdown
Contributor Author

htmlboy commented Mar 19, 2020

@ivan-mr Hi, I'm sorry for the late response. I thought this pattern was already on the interface, but perhaps only on the design module? Could you provide a unified pattern for that?

@ivan-mr ivan-mr closed this Apr 2, 2020
@tramuntanal tramuntanal deleted the feature/activity-cards branch June 25, 2020 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants