Merged
Conversation
Contributor
Author
|
@decidim/core this has been approved by @decidim/product, can you review it please? |
5119eee to
e547d20
Compare
5 tasks
leio10
previously approved these changes
Feb 6, 2020
Contributor
leio10
left a comment
There was a problem hiding this comment.
Very nice use of the local storage 👍
tramuntanal
suggested changes
Feb 9, 2020
Contributor
There was a problem hiding this comment.
Amazing job @mrcasals!
Just one usability detail and we're done :D
Also a merge from master is required 😄
e547d20 to
dc742f4
Compare
Contributor
Author
|
@tramuntanal I've rebased from |
tramuntanal
approved these changes
Feb 10, 2020
microstudi
pushed a commit
to Platoniq/decidim
that referenced
this pull request
Feb 21, 2020
* Add icon to comment reply buttons * Hide and show comment threads * Add changelog * Lint code * Save thread state in localStorage * Lint code * Update bundle * Mock localStorage on tests * Add pointer cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR lets users show and hide comment threads to improve reading.
📌 Related Issues
📋 Subtasks
CHANGELOGentry📷 Screenshots (optional)
Showing the thread (notice how there are 3 replies):
Hiding the thread (notice how it correctly counts replies):
