Skip to content

Fix faker version#547

Merged
mrcasals merged 1 commit intomasterfrom
add_faker_as_a_hard_dependency
Jan 19, 2017
Merged

Fix faker version#547
mrcasals merged 1 commit intomasterfrom
add_faker_as_a_hard_dependency

Conversation

@josepjaume
Copy link
Copy Markdown
Contributor

🎩 What? Why?

This ensures the generated app's faker version being used is the same as the app's, without explicitly setting it as runtime dependency.

This fixes staging environments.

📌 Related Issues

None

📋 Subtasks

None

📷 Screenshots (optional)

None

👻 GIF

@josepjaume josepjaume force-pushed the add_faker_as_a_hard_dependency branch from fc40d3e to 1b2cb5c Compare January 19, 2017 14:03
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 19, 2017

Current coverage is 97.19% (diff: 100%)

Merging #547 into master will not change coverage

@@             master       #547   diff @@
==========================================
  Files           255        255          
  Lines          3990       3990          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           3878       3878          
  Misses          112        112          
  Partials          0          0          

Powered by Codecov. Last update 10f1455...1b2cb5c

@mrcasals mrcasals merged commit acc76df into master Jan 19, 2017
@mrcasals mrcasals deleted the add_faker_as_a_hard_dependency branch January 19, 2017 15:10
aitorlb pushed a commit to CodiTramuntana/decidim that referenced this pull request Aug 8, 2019
* [BACKPORT] Fix user presenter for user groups (decidim#4974)

* Fix user presenter for user groups (decidim#4973)

* Fix user presenter for user groups

The user groups do not have a `.deleted?` method defined for them
which caused the user presenter to break the notifications view
in case the notification was linking to a group user.

* Add CHANGELOG entry

* Fix changelog

* 🐛 ⏪ Better fixes for decidim#525

- reverting 25bd9a4
- reverting 7b6f2e5
- better fix comes from decidim@7372946

* 🌐 amendable event FR label decidim#532

* 🐛 HashtagRenderer in comment events decidim#532

* 🐛 fix step_cta_path decidim#488

* 🌐 [pages] FR "Titre" >> "Page" !
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants