Leverage with_context in form factories#488
Merged
josepjaume merged 6 commits intomasterfrom Jan 13, 2017
Merged
Conversation
with_context in form factorieswith_context in form factories
with_context in form factorieswith_context in form factories
mrcasals
approved these changes
Jan 11, 2017
Current coverage is 60.27% (diff: 100%)@@ master #488 diff @@
==========================================
Files 2824 2816 -8
Lines 121487 120632 -855
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 73048 72710 -338
+ Misses 48439 47922 -517
Partials 0 0
|
24ea5d8 to
136f623
Compare
with_context in form factorieswith_context in form factories [WIP]
1b04759 to
ad28eb3
Compare
with_context in form factories [WIP]with_context in form factories
|
@josepjaume, thanks for your PR! By analyzing the history of the files in this pull request, we identified @oriolgual and @mrcasals to be potential reviewers. |
aitorlb
pushed a commit
to CodiTramuntana/decidim
that referenced
this pull request
Aug 8, 2019
aitorlb
pushed a commit
to CodiTramuntana/decidim
that referenced
this pull request
Aug 8, 2019
aitorlb
pushed a commit
to CodiTramuntana/decidim
that referenced
this pull request
Aug 8, 2019
* [BACKPORT] Fix user presenter for user groups (decidim#4974) * Fix user presenter for user groups (decidim#4973) * Fix user presenter for user groups The user groups do not have a `.deleted?` method defined for them which caused the user presenter to break the notifications view in case the notification was linking to a group user. * Add CHANGELOG entry * Fix changelog * 🐛 ⏪ Better fixes for decidim#525 - reverting 25bd9a4 - reverting 7b6f2e5 - better fix comes from decidim@7372946 * 🌐 amendable event FR label decidim#532 * 🐛 HashtagRenderer in comment events decidim#532 * 🐛 fix step_cta_path decidim#488 * 🌐 [pages] FR "Titre" >> "Page" !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This improves form factories so they make use of
with_context, fixing several bugs related to the way we were emulatingfrom_modelin the past.📌 Related Issues
with_contextin ourFormFactory#360📋 Subtasks
None
📷 Screenshots (optional)
None
👻 GIF