Skip to content

Setup CircleCI#5

Merged
oriolgual merged 1 commit intomasterfrom
fix_circle_ci
Sep 15, 2016
Merged

Setup CircleCI#5
oriolgual merged 1 commit intomasterfrom
fix_circle_ci

Conversation

@oriolgual
Copy link
Copy Markdown
Contributor

🎩 What? Why?

We need the CI working in order to make sure the project is building OK.

🎯 Acceptance criteria?

CircleCI is green.

👻 GIF

@oriolgual oriolgual force-pushed the fix_circle_ci branch 3 times, most recently from 9e8ba53 to de06451 Compare September 15, 2016 10:00
Copy link
Copy Markdown
Contributor

@josepjaume josepjaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, just do the changes I request and ready to go!

Rakefile Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we make this the default test task?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the circle.yml so we don't need a specific CI task 🎉

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@oriolgual oriolgual force-pushed the fix_circle_ci branch 3 times, most recently from 245d2dc to 5774353 Compare September 15, 2016 10:24
@oriolgual oriolgual merged commit c27c0d0 into master Sep 15, 2016
@oriolgual oriolgual deleted the fix_circle_ci branch September 15, 2016 10:37
Quentinchampenois referenced this pull request in Quentinchampenois/decidim Apr 3, 2020
…uestions

Feature/admin manages questions
Quentinchampenois referenced this pull request in Quentinchampenois/decidim Apr 3, 2020
tramuntanal added a commit that referenced this pull request Apr 17, 2020
* Add two cta on initiative

* Normalize locales

* Normalize locales

* Add changelog entry

* Update cta redirection (#9)

* erb files linting

* change cta redirection to initiatives_path

* Use EngineRouter main_proxy for redirection

* Add two missing tests (#5)

Co-authored-by: Armand Fardeau <armandfardeau@users.noreply.github.com>

Co-authored-by: Quentin Champ <26109239+Quentinchampenois@users.noreply.github.com>
Co-authored-by: Oliver Valls <oliver.vh@coditramuntana.com>
agustibr pushed a commit that referenced this pull request Apr 20, 2020
* Add two cta on initiative

* Normalize locales

* Normalize locales

* Add changelog entry

* Update cta redirection (#9)

* erb files linting

* change cta redirection to initiatives_path

* Use EngineRouter main_proxy for redirection

* Add two missing tests (#5)

Co-authored-by: Armand Fardeau <armandfardeau@users.noreply.github.com>

Co-authored-by: Quentin Champ <26109239+Quentinchampenois@users.noreply.github.com>
Co-authored-by: Oliver Valls <oliver.vh@coditramuntana.com>
faithngetich pushed a commit to faithngetich/decidim that referenced this pull request Apr 28, 2020
* Add two cta on initiative

* Normalize locales

* Normalize locales

* Add changelog entry

* Update cta redirection (decidim#9)

* erb files linting

* change cta redirection to initiatives_path

* Use EngineRouter main_proxy for redirection

* Add two missing tests (decidim#5)

Co-authored-by: Armand Fardeau <armandfardeau@users.noreply.github.com>

Co-authored-by: Quentin Champ <26109239+Quentinchampenois@users.noreply.github.com>
Co-authored-by: Oliver Valls <oliver.vh@coditramuntana.com>
microstudi added a commit that referenced this pull request May 21, 2020
* permit user_groups to be part in a conversation

* display avatars always in 1:1 proportion with cover object fit

* show groups in conversations page

* show different messages per mailbox

* enable responding group conversations

* revert avatar changes

* revert mailbox group messages handeling

* add cuser_conversation controller

* add user_conversation controller specs

* Fix supported versions in SECURITY.md (#5957)

* Fix supported versions in SECURITY.md

* Add changelog entry

* Conversations with more than one participant (#5861)

* Allow to create conversations with more than one participant

* Added new form param to converstation controller

* Check conversation with multiple users

* Clean code debugs

* Added changelog file

* Cleans debug code line

* Fixes rubocop offenses

* Fixes some js lints

* Disable mentioning users with notifications disabled

* Fixes a) some js linter issues b) refactor some helper methods c) added more conversation_controller_spec tests

* Adds multiple participants's conversations rspec tests

* Add validations for avoiding selecting users with disabled notifications for conversations

* Add test for mention with disabled users

* Fixes a) unused translations tags b) Fixed conversations index test

* Fixes js linter issues

* Fixes a) conversation form validator b) conversations controller test

* Normalizes en.yml locales file

* Fixes linter conversation index erb template

* Add start_conversation_dialog.js to precompiler

* Fixes conversation js tag dependency

* Applies some PR's CR suggestions: a) Move deleteRecipient method  inside anonymous function b)

* Modification of name class for disabled tribute element and modification of jquery selector by javascript selector on tribute.js library

* Fix users on selectable mention list shown disabled by acceptance of conversation value

* Fixes multiple mention dropdown style. Adds no results translation

* Normalizes locale en.yml file

* Remove scope selecting only follower user due to a subsequent validation

* Adds avatar to user's dropdown multi-mention, to be like mention

* Fixes a) js includes b) enlights multiple mention input placeholder

* Rename disabledNotifications by directMessagesEnabled field on api

* Rewrite context message on conversations_spec.rb on mentioned list

* Add initial comment to inform that the original file is modified to include a modification on click event

* Fix lint errors

* Remove defined field directMessagesEnabled from author_interface and user_group_type and change api call from input_multiple_mentions.js.es6

* Fixes some styling changes to add users to conversation modal dialog

* Fixes a) unnecessary setTime function call b) change on input placeholder c) adds extra label with max users information d) some translations

* Modify user presenter to return boolean on directMessagesEnabled

* Add spec for directMessagesEnabled

* Fix lint rubocop issues

* Adds a debounce delay call to avoid api calls when keys are pressed so fast

* Fixed translations en.yml lint

* Adds some accessibility functionality on New Conversation modal

* Fixes some lints

* Update CHANGELOG.md

Co-Authored-By: Ivan Vergés <ivan@platoniq.net>

* Adds some more aria pattern to relate label and input elements

* Update decidim-core/app/presenters/decidim/user_presenter.rb

Co-Authored-By: Ivan Vergés <ivan@platoniq.net>

* Fixes bad code review merge for api user presenter

* Fixes linter issue

Co-authored-by: Ivan Molinero <ivan.mr@coditramuntana.com>
Co-authored-by: Jesús Di Bari <jesus.db@coditramuntana.com>
Co-authored-by: Ivan Vergés <ivan@platoniq.net>

* Add two CTA on initiative (#5838)

* Add two cta on initiative

* Normalize locales

* Normalize locales

* Add changelog entry

* Update cta redirection (#9)

* erb files linting

* change cta redirection to initiatives_path

* Use EngineRouter main_proxy for redirection

* Add two missing tests (#5)

Co-authored-by: Armand Fardeau <armandfardeau@users.noreply.github.com>

Co-authored-by: Quentin Champ <26109239+Quentinchampenois@users.noreply.github.com>
Co-authored-by: Oliver Valls <oliver.vh@coditramuntana.com>

* Don't follow the header x forwarded host by default (#5899)

* Don't follow the header x forwarded host by default

* Use accessor directly

* Add changelog entry

Co-authored-by: Oliver Valls <oliver.vh@coditramuntana.com>

* Remove legacy assembly types (#5617)

* migration to remove legacy fields

* fix changelog

* rename migration

Co-authored-by: Oliver Valls <oliver.vh@coditramuntana.com>

* add groups to multiple conversations

* add groups to spec system conversations

* generalize sender in conversation commands

* add form and listing in user_group_controller

* [WIP] add from parameter to messages for create receipts in groups

* create receipts and send emails for members of groups

* new conversation in profile (WIP)

* new conversation (WIP2)

* new messages working. pagination

* distinct messages for and as a group

* prevent users to receive emails if have direct messages disabled

* complete permissions specs

* add user_conversations controller specs

* add start and reply conversation spec cases

* add profile conversations system specs

* complete specs for profile conversations

* add changelog

* add badge of total number of unreaded messages

* add styling for conversations list

* apply new design to conversation thread

* apply linter

* bundle javascript

* fix assets assignation in object Decidim

* fix tests for the new design

* improve conversations model tests

* move css helpers from initiatives to core

* adjust design in profile and user conversations

* fix missing templates in ajax updates

* fix create conversation

* fix css padding

* style fix

* fix message receipts count in conversation pages

* document why there's a function returning true only

* fix number of receipts counter in group

* add specs for conversation page

Co-authored-by: Oliver Valls <oliver.vh@coditramuntana.com>
Co-authored-by: Ramon Costa <ramon.costa@gmail.com>
Co-authored-by: Ivan Molinero <ivan.mr@coditramuntana.com>
Co-authored-by: Jesús Di Bari <jesus.db@coditramuntana.com>
Co-authored-by: Armand Fardeau <armandfardeau@users.noreply.github.com>
Co-authored-by: Quentin Champ <26109239+Quentinchampenois@users.noreply.github.com>
Leusev added a commit that referenced this pull request Jun 3, 2020
* Add assemblies to participatory process

* Add changelog entry [skip ci]

* light fix (#5)

* Fix conflicts in assemblies locales file (#10)

* merge develop

* resolve assemblies locales conflict

* Fix unused

* Use card for instead of helper

* Don't display private spaces unless transparents

* Remove duplicate

Co-authored-by: Quentin Champ <26109239+Quentinchampenois@users.noreply.github.com>
Co-authored-by: Oliver Valls <oliver.vh@coditramuntana.com>
Co-authored-by: Ramon Costa <ramon.costa@gmail.com>
@andreslucena andreslucena mentioned this pull request Sep 15, 2020
1 task
tramuntanal pushed a commit that referenced this pull request Jan 13, 2021
…oid_removing_style_on_sanitize

Backport "fix avoid removing tag style on custom sanitize" to v0.22-stable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants