Allow groups to have conversations with other groups or users by microstudi · Pull Request #6009 · decidim/decidim

microstudi · 2020-04-21T13:44:55Z

🎩 What? Why?

Allow groups to have private conversations between them and/or normal users.
It uses the multi-user messaging capabilities introduced in #5681.

Groups can start new conversations from their profile page. Normal users still maintain the independent conversation page but they can have conversations with groups too.

Notes:

when a group send a message, all their co-admins receive a message informing of the fact.
when a user writes to a user, all its co-admins receive the message.
co-admins will never receive an email if they have the "restrict direct messages" introduced in Feature/receive messages from everyone #5720 on, unless they specifically follow the group.
conversations between members of the group ant its own group are allowed.

There are 6 types of templates for an email sent (class ConversationMailer) as a result of this:

message to human recipients when starting a new conversation new_conversation
message to admins of the group when a recipient is this group and someone started a new conversation new_group_conversation
message to co-admins of a group when this group starts a new conversation comanagers_new_conversation
message to human recipients when posting a new message in an existing conversation new_message
message to admins of the group when a recipient is this group and someone posted a new message in an existing conversation new_group_message
message to co-admins of a group when this group posts a new message in an existing conversation comanagers_new_message

📌 Related Issues

Fixes Send private messages to groups #5776

📋 Subtasks

Add CHANGELOG entry
Add tests

📷 Screenshots (optional)

* Fix supported versions in SECURITY.md * Add changelog entry

* Allow to create conversations with more than one participant * Added new form param to converstation controller * Check conversation with multiple users * Clean code debugs * Added changelog file * Cleans debug code line * Fixes rubocop offenses * Fixes some js lints * Disable mentioning users with notifications disabled * Fixes a) some js linter issues b) refactor some helper methods c) added more conversation_controller_spec tests * Adds multiple participants's conversations rspec tests * Add validations for avoiding selecting users with disabled notifications for conversations * Add test for mention with disabled users * Fixes a) unused translations tags b) Fixed conversations index test * Fixes js linter issues * Fixes a) conversation form validator b) conversations controller test * Normalizes en.yml locales file * Fixes linter conversation index erb template * Add start_conversation_dialog.js to precompiler * Fixes conversation js tag dependency * Applies some PR's CR suggestions: a) Move deleteRecipient method inside anonymous function b) * Modification of name class for disabled tribute element and modification of jquery selector by javascript selector on tribute.js library * Fix users on selectable mention list shown disabled by acceptance of conversation value * Fixes multiple mention dropdown style. Adds no results translation * Normalizes locale en.yml file * Remove scope selecting only follower user due to a subsequent validation * Adds avatar to user's dropdown multi-mention, to be like mention * Fixes a) js includes b) enlights multiple mention input placeholder * Rename disabledNotifications by directMessagesEnabled field on api * Rewrite context message on conversations_spec.rb on mentioned list * Add initial comment to inform that the original file is modified to include a modification on click event * Fix lint errors * Remove defined field directMessagesEnabled from author_interface and user_group_type and change api call from input_multiple_mentions.js.es6 * Fixes some styling changes to add users to conversation modal dialog * Fixes a) unnecessary setTime function call b) change on input placeholder c) adds extra label with max users information d) some translations * Modify user presenter to return boolean on directMessagesEnabled * Add spec for directMessagesEnabled * Fix lint rubocop issues * Adds a debounce delay call to avoid api calls when keys are pressed so fast * Fixed translations en.yml lint * Adds some accessibility functionality on New Conversation modal * Fixes some lints * Update CHANGELOG.md Co-Authored-By: Ivan Vergés <ivan@platoniq.net> * Adds some more aria pattern to relate label and input elements * Update decidim-core/app/presenters/decidim/user_presenter.rb Co-Authored-By: Ivan Vergés <ivan@platoniq.net> * Fixes bad code review merge for api user presenter * Fixes linter issue Co-authored-by: Ivan Molinero <ivan.mr@coditramuntana.com> Co-authored-by: Jesús Di Bari <jesus.db@coditramuntana.com> Co-authored-by: Ivan Vergés <ivan@platoniq.net>

* Add two cta on initiative * Normalize locales * Normalize locales * Add changelog entry * Update cta redirection (#9) * erb files linting * change cta redirection to initiatives_path * Use EngineRouter main_proxy for redirection * Add two missing tests (#5) Co-authored-by: Armand Fardeau <armandfardeau@users.noreply.github.com> Co-authored-by: Quentin Champ <26109239+Quentinchampenois@users.noreply.github.com> Co-authored-by: Oliver Valls <oliver.vh@coditramuntana.com>

* Don't follow the header x forwarded host by default * Use accessor directly * Add changelog entry Co-authored-by: Oliver Valls <oliver.vh@coditramuntana.com>

* migration to remove legacy fields * fix changelog * rename migration Co-authored-by: Oliver Valls <oliver.vh@coditramuntana.com>

# Conflicts: # decidim-core/app/assets/javascripts/decidim/input_multiple_mentions.js.es6 # decidim-core/app/commands/decidim/messaging/start_conversation.rb # decidim-core/app/controllers/decidim/messaging/conversations_controller.rb # decidim-core/app/forms/decidim/messaging/conversation_form.rb # decidim-core/app/helpers/decidim/messaging/conversation_helper.rb # decidim-core/spec/system/messaging/conversations_spec.rb

tramuntanal · 2020-05-07T08:21:39Z

hi @microstudi , tests in develop branch are succeeding it seems that the problem is in this branch. Can you check the tests locally please?

microstudi · 2020-05-12T19:34:13Z

@tramuntanal , this is finished!

Leusev

Wow! Great job @microstudi
I only left a couple of minor things 🔍
There's changelog file conflict too

decidim-core/app/models/decidim/user_group.rb

Leusev · 2020-05-19T12:46:52Z

decidim-core/app/views/decidim/messaging/conversations/show.html.erb

+    <% user_grouped_messages.each do |sender, messages| %>
+        <%= render "messages", sender: sender, messages: messages %>
+    <% end %>
    <% conversation.messages.each do |message| %>


Could this conversation.messages.each block left over? it seems it makes an unnecessary loop with an empty code block

indeed! good catch!

microstudi · 2020-05-20T20:17:07Z

@Leusev it should be ok now!

Leusev

Looks good for me @microstudi
Only if you could take a look at that changelog entry
Thanks!!

CHANGELOG.md

Leusev

I swear I saw it 🙄 😅
All ok now!! 😄

microstudi · 2020-05-21T15:15:53Z

@decidim/product is this ok from your side? have you tested it?

carolromero · 2020-05-21T15:41:58Z

yep, checked! 👍 well done @microstudi

mrcasals · 2020-05-25T09:15:35Z

This PR causes some test failures:

https://github.com/decidim/decidim/runs/704413614

Can you check this? @microstudi

microstudi · 2020-05-25T13:13:26Z

Thanks @mrcasals looking at it. strange as tests where fine before merging.

microstudi · 2020-05-25T14:00:14Z

This seems to be a flaky test... after restart the job succeeded

microstudi and others added 30 commits March 31, 2020 20:04

permit user_groups to be part in a conversation

5081367

display avatars always in 1:1 proportion with cover object fit

0cdc0d0

show groups in conversations page

cd13bc7

show different messages per mailbox

890978d

enable responding group conversations

1771c6e

Merge branch 'develop' into feature/send-to-groups

d796850

revert avatar changes

38d053f

revert mailbox group messages handeling

fe155b1

add cuser_conversation controller

ea20c88

add user_conversation controller specs

a7d61c2

Fix supported versions in SECURITY.md (decidim#5957)

cd22e07

* Fix supported versions in SECURITY.md * Add changelog entry

Don't follow the header x forwarded host by default (decidim#5899)

fa90b6b

* Don't follow the header x forwarded host by default * Use accessor directly * Add changelog entry Co-authored-by: Oliver Valls <oliver.vh@coditramuntana.com>

Remove legacy assembly types (decidim#5617)

993c9f2

* migration to remove legacy fields * fix changelog * rename migration Co-authored-by: Oliver Valls <oliver.vh@coditramuntana.com>

add groups to multiple conversations

baf3d4a

add groups to spec system conversations

d3ea11f

generalize sender in conversation commands

cf11535

add form and listing in user_group_controller

3f8ecd2

[WIP] add from parameter to messages for create receipts in groups

4fa352d

create receipts and send emails for members of groups

b11c57e

new conversation in profile (WIP)

747fa31

new conversation (WIP2)

15a31b1

new messages working. pagination

bbd0fc5

distinct messages for and as a group

7082167

prevent users to receive emails if have direct messages disabled

b4fd19f

complete permissions specs

7d8c060

add user_conversations controller specs

c005885

add start and reply conversation spec cases

c058af7

microstudi added 10 commits May 11, 2020 20:31

Merge branch 'develop' into feature/send-to-groups

9a30eca

fix assets assignation in object Decidim

b18de9a

fix tests for the new design

3b815bb

improve conversations model tests

e69da55

move css helpers from initiatives to core

085058a

adjust design in profile and user conversations

db64af7

fix missing templates in ajax updates

9bf1311

fix create conversation

bcbd00b

fix css padding

d03e99c

style fix

ab36489

Merge branch 'develop' into feature/send-to-groups

0e675e0

Leusev suggested changes May 19, 2020

View reviewed changes

microstudi added 5 commits May 19, 2020 17:47

Merge branch 'develop' into feature/send-to-groups

0d58620

fix message receipts count in conversation pages

8fe2bfd

document why there's a function returning true only

7bfb4b9

fix number of receipts counter in group

e2e3048

add specs for conversation page

dcb03e1

Leusev suggested changes May 21, 2020

View reviewed changes

CHANGELOG.md Show resolved Hide resolved

Leusev self-requested a review May 21, 2020 14:52

Leusev approved these changes May 21, 2020

View reviewed changes

microstudi merged commit 62db551 into decidim:develop May 21, 2020

mrcasals mentioned this pull request May 25, 2020

Separate forms in steps #6108

Merged

8 tasks

Uh oh!

Conversation

microstudi commented Apr 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎩 What? Why?

📌 Related Issues

📋 Subtasks

📷 Screenshots (optional)

Uh oh!

tramuntanal commented May 7, 2020

Uh oh!

microstudi commented May 12, 2020

Uh oh!

Leusev left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Leusev May 19, 2020

Choose a reason for hiding this comment

Uh oh!

microstudi May 20, 2020

Choose a reason for hiding this comment

Uh oh!

microstudi commented May 20, 2020

Uh oh!

Leusev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Leusev left a comment

Choose a reason for hiding this comment

Uh oh!

microstudi commented May 21, 2020

Uh oh!

carolromero commented May 21, 2020

Uh oh!

mrcasals commented May 25, 2020

Uh oh!

microstudi commented May 25, 2020

Uh oh!

microstudi commented May 25, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

microstudi commented Apr 21, 2020 •

edited

Loading

Leusev left a comment •

edited

Loading