Skip to content

Make authors polymorphic#4282

Merged
mrcasals merged 3 commits intomasterfrom
polymorphic-authors
Oct 19, 2018
Merged

Make authors polymorphic#4282
mrcasals merged 3 commits intomasterfrom
polymorphic-authors

Conversation

@oriolgual
Copy link
Copy Markdown
Contributor

@oriolgual oriolgual commented Oct 16, 2018

🎩 What? Why?

Changes authors in Debates, Proposals and Initiatives (so far) to make them polymorphic. Now, official resources have the author as the organization.

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG entry
  • Add documentation regarding the feature
  • Add/modify seeds
  • Add tests
  • Add organization as author for official proposals
  • Add organization as author for official debates
  • Migrate columns for debates
  • Migrate columns for proposals
  • Migrate columns for initiatives
  • Migrate columns for posts
  • Migrate columns for sortitions
  • Migrate columns for endorsements
  • Migrate columns for comments
  • Migrate columns for dummy resource
  • Set organization as author when creating a proposal from the admin
  • Set organization as author when creating a debate from the admin
  • Forward proposal notifications to admins & space admin (see NotifyProposalsMentionedJob)
  • Forward debate notifications to admins & space admin

@ghost ghost assigned oriolgual Oct 16, 2018
@ghost ghost added the status: WIP label Oct 16, 2018
@oriolgual oriolgual force-pushed the polymorphic-authors branch 11 times, most recently from 0b64c2f to acfcd2c Compare October 18, 2018 10:11
@oriolgual
Copy link
Copy Markdown
Contributor Author

@agustibr @tramuntanal 👀

@oriolgual oriolgual force-pushed the polymorphic-authors branch 2 times, most recently from 749ca6d to 1e8f900 Compare October 18, 2018 10:47
SIMPLECOV: true
DATABASE_USERNAME: postgres
FAIL_FAST: true
FAIL_FAST: false
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please undo this

@oriolgual oriolgual force-pushed the polymorphic-authors branch 2 times, most recently from 2957c19 to 908acbc Compare October 18, 2018 12:40
@ghost ghost added the status: WIP label Oct 18, 2018
mrcasals
mrcasals previously approved these changes Oct 18, 2018
@mrcasals
Copy link
Copy Markdown
Contributor

@oriolgual tests are failing!

@oriolgual oriolgual force-pushed the polymorphic-authors branch from 3c14dc2 to 5bc7cfe Compare October 19, 2018 07:44
mrcasals
mrcasals previously approved these changes Oct 19, 2018
agustibr
agustibr previously approved these changes Oct 19, 2018
Copy link
Copy Markdown
Contributor

@agustibr agustibr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woow, awesome! 👍

@oriolgual oriolgual dismissed stale reviews from agustibr and mrcasals via b2e87e6 October 19, 2018 09:33
@oriolgual oriolgual force-pushed the polymorphic-authors branch from 5bc7cfe to b2e87e6 Compare October 19, 2018 09:33
@ghost ghost added the status: WIP label Oct 19, 2018
mrcasals
mrcasals previously approved these changes Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants