Use optional gems in development app#3362
Conversation
And thus, optional gem migrations are installed and run.
|
I think we should enable it, @josepjaume are you OK with this? |
josepjaume
left a comment
There was a problem hiding this comment.
Fine for me, but would like @oriolgual to confirm it works for him!
| gem "decidim-consultations", path: "decidim-consultations" | ||
| gem "decidim-initiatives", path: "decidim-initiatives" | ||
| gem "decidim-consultations", path: "." | ||
| gem "decidim-initiatives", path: "." |
There was a problem hiding this comment.
@oriolgual and I had some back-and-forth with this, as it didn't work for him using . as a relative path. Might have to do with the ruby version manager used. @oriolgual can you confirm this works for you?
There was a problem hiding this comment.
I should work because we're doing the same for decidim and decidim-dev, no?
There was a problem hiding this comment.
I can't actually remember this 😅
But if it fails only at my computer then it's an issue with my setup, not Decidim's
There was a problem hiding this comment.
Well it might indicate a flaw with the approach. But let's do this!
|
By the way, I think this was the way it originally worked (at least I rememeber seeing |
* Add a rake task to bundle all gemfiles at once * Normalize optional gems paths * Make sure migrations pick the right Gemfile And thus, optional gem migrations are installed and run. * Use optional gems in "demo apps"
* Fix dev app's gemfile for external plugins (#3313) * Correct optional gems location when generating app Otherwise we get an error bundling it in external plugins since there's no local folder in the final app: ``` The path `/path/to/decidim/development_app/decidim-consultations` does not exist ``` * Read gemspec only once * Add a change log entry * Update ruby to version 2.5.1 (#3293) * Update Gemfile.lock to update erb_lint to v 0.0.24 * fix erb_lint errors * update to ruby 2.5.1 * Use ruby 2.5.1's docker image * Update decidim-generators Gemfile.lock * Update decidim_app-design Gemfile.lock * Update decidim_app-design Gemfile.lock (2) * Use optional gems in development app (#3362) * Add a rake task to bundle all gemfiles at once * Normalize optional gems paths * Make sure migrations pick the right Gemfile And thus, optional gem migrations are installed and run. * Use optional gems in "demo apps"
* Add a rake task to bundle all gemfiles at once * Normalize optional gems paths * Make sure migrations pick the right Gemfile And thus, optional gem migrations are installed and run. * Use optional gems in "demo apps"
🎩 What? Why?
Currently optional gems (consultations & initiatives) are not used when generating a development app. I think we should probably use them in development?
@mrcasals @oriolgual This might be relevant for your demo.
📌 Related Issues
None.
📋 Subtasks
None.
📷 Screenshots (optional)
None.