Fix external plugin app generation#3470
Merged
mrcasals merged 4 commits into0.11-stablefrom May 22, 2018
Merged
Conversation
* Correct optional gems location when generating app Otherwise we get an error bundling it in external plugins since there's no local folder in the final app: ``` The path `/path/to/decidim/development_app/decidim-consultations` does not exist ``` * Read gemspec only once
* Update Gemfile.lock to update erb_lint to v 0.0.24 * fix erb_lint errors * update to ruby 2.5.1 * Use ruby 2.5.1's docker image * Update decidim-generators Gemfile.lock * Update decidim_app-design Gemfile.lock * Update decidim_app-design Gemfile.lock (2)
* Add a rake task to bundle all gemfiles at once * Normalize optional gems paths * Make sure migrations pick the right Gemfile And thus, optional gem migrations are installed and run. * Use optional gems in "demo apps"
mrcasals
approved these changes
May 22, 2018
Contributor
|
Thanks for taking care of that! 😍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Currently dummy app generation for external plugins doesn't work on 0.11.1. This is because the PR introducing the bug (#3224) made it to the release, but the fix (#3313) didn't. So I'm backporting the fix.
#3313 fixed the bug, but unintentionally introduced another bug (optional gems not being used in development). So I'm also backporting #3362 as well, the fix to that other issue.
Finally, I'm also backporting #3293 for convenience when working on backports.
📌 Related Issues
📋 Subtasks
CHANGELOGentry📷 Screenshots (optional)
None.