Conversation
Contributor
Author
|
Hey @decidim/lot-core, can you take a global review and give your opinion, please? |
oriolgual
suggested changes
May 9, 2018
| visible: @form.visible, | ||
| meeting: @meeting | ||
| ) | ||
| create_agenda_items |
Contributor
There was a problem hiding this comment.
Not super important, but I'd move this to call for better readability
|
|
||
| def update_nested_model(form, attributes, agenda_item_childs) | ||
| record = agenda_item_childs.find_by(id: form.id) || agenda_item_childs.build(attributes) | ||
| # record = Decidim::Meetings::AgendaItem.find_or_create_by!(attributes) |
| # Broadcasts :ok if successful, :invalid otherwise. | ||
| def call | ||
| return broadcast(:invalid) if form.invalid? | ||
| # return broadcast(:invalid) if @meeting.meeting_duration < form.agenda_items.sum(&:duration) |
| class UpdateAgenda < Rectify::Command | ||
| def initialize(form, meeting, agenda) | ||
| @form = form | ||
| @meeting = meeting |
| agenda_items.each do |agenda_item| | ||
| duration_childs += agenda_item.agenda_item_childs.sum(&:duration) | ||
| end | ||
| duration + duration_childs |
Contributor
There was a problem hiding this comment.
Maybe you don't need to initalize the values?
What about this?
(agenda_items.map(&:duration) + agenda_items.map(&:agenda_item_childs).map(&:duration).sum| end | ||
|
|
||
| def agenda_item_childs_duration_lower_than_or_equal_than_parent | ||
| # return true unless self.agenda_item_childs.presence |
| end | ||
|
|
||
| def set_agenda_items_start_end_times(agenda_items, meeting, start_time_parent = nil) | ||
| array = [] |
Contributor
There was a problem hiding this comment.
Could you please use a more meaningful variable name? 😅
|
|
||
| module Decidim | ||
| module Meetings | ||
| # The data store for a Meeting in the Decidim::Meetings component. It stores a |
|
|
||
| module Decidim | ||
| module Meetings | ||
| # The data store for a Meeting in the Decidim::Meetings component. It stores a |
| end | ||
|
|
||
| def meeting_duration | ||
| ((end_time - start_time) * 24 * 60).to_i |
Contributor
There was a problem hiding this comment.
@meeting_duration ||= maybe?
6 tasks
f1e89a8 to
5346abf
Compare
74 tasks
5346abf to
4920ba5
Compare
9f13d09 to
f93c253
Compare
f93c253 to
9685caa
Compare
Contributor
|
@decidim/lot-core ready to review. |
oriolgual
suggested changes
Jun 5, 2018
| }); | ||
|
|
||
| const createDynamicFieldsForAgendaItemChilds = (fieldId) => { | ||
| // const autoButtons = createAutoButtonsByMinItemsForAnswerOptions(fieldId); |
|
|
||
| hideDeletedAgendaItem($target); | ||
| setupInitialAgendaItemChildAttributes($target); | ||
| // createDynamicFieldsForAgendaItemChilds($target) |
| end | ||
|
|
||
| def agenda_duration | ||
| agenda_items.sum(&:duration) |
Contributor
There was a problem hiding this comment.
Memoize this?
@agenda_item ||= agenda_items.sum(&:duration)
| @meeting ||= context[:meeting] | ||
| end | ||
|
|
||
| def agenda_duration_lt_meeting_duration |
Contributor
There was a problem hiding this comment.
Maybe agenda_duration_too_long?
| agenda_items.sum(&:duration) | ||
| end | ||
|
|
||
| def agenda_item_duration_lt_than_parent |
Contributor
There was a problem hiding this comment.
agenda_items_duration_too_long ?
| end | ||
| end | ||
|
|
||
| # Public: This method is used to calc the start and end time |
Contributor
|
@oriolgual, recommendations applied. |
oriolgual
approved these changes
Jun 5, 2018
josepjaume
pushed a commit
that referenced
this pull request
Jun 6, 2018
* Add meeting agenda and agenda items (@isaacmg410) * Add change log entry (@isaacmg410) * Add specs * Enforce permissions in controller * Remove commented code and improve functions names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR is to add meeting agenda CRUD
📌 Related Issues
📋 Subtasks
CHANGELOGentry📷 Screenshots (optional)