Skip to content

Prevent reload on filters when the 'Skip to' links are clicked#15233

Merged
alecslupu merged 1 commit intodevelopfrom
fix/a11y/skip-to-content-reload
Sep 26, 2025
Merged

Prevent reload on filters when the 'Skip to' links are clicked#15233
alecslupu merged 1 commit intodevelopfrom
fix/a11y/skip-to-content-reload

Conversation

@andreslucena
Copy link
Copy Markdown
Member

🎩 What? Why?

There's an accessibility problem with the current "Skip to main content", "Skip to results" and "Skip map" links in all the pages with filters. The problem is that the filter is executed again when any of these links is clicked.

This shouldn't happen, as the filters shouldn't change by this action. It is specially painful in meetings#index page, as it has these three links and also there's a map. There's a full explanation about this issue at #11522.

You can check out the reload of the filters through the "Network" tab of your browsers' web developer tools.

📌 Related Issues

Testing

  1. Go to /meetings (or any other view with filters and map)
  2. Using tab navigation, click the "Skip to content" link
  3. See that the dynamic filtering triggers
  4. Repeat the exercise by going to the "Skip to map" link
  5. See the same behavior
  6. Apply this patch
  7. See that these behaviors are corrected

(I also found this same problem with the "Skip to results" link)

📷 Screenshots

image

♥️ Thank you!

github-actions[bot]
github-actions bot previously approved these changes Sep 25, 2025
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alecslupu alecslupu added the release: v0.31 Issues or PRs that need to be tackled for v0.31 label Sep 26, 2025
@alecslupu alecslupu added this to the 0.32.0 milestone Sep 26, 2025
@alecslupu alecslupu merged commit e8d3e4b into develop Sep 26, 2025
90 of 94 checks passed
@alecslupu alecslupu deleted the fix/a11y/skip-to-content-reload branch September 26, 2025 19:18
@alecslupu alecslupu added release: v0.29 Issues or PRs that need to be tackled for v0.29 release: v0.30 Issues or PRs that need to be tackled for v0.30 labels Sep 26, 2025
alecslupu pushed a commit to i-need-another-coffee/decidim that referenced this pull request Oct 3, 2025
MariaDascaluPublicis pushed a commit to i-need-another-coffee/decidim that referenced this pull request Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: core project: 2025-NGI release: v0.29 Issues or PRs that need to be tackled for v0.29 release: v0.30 Issues or PRs that need to be tackled for v0.30 release: v0.31 Issues or PRs that need to be tackled for v0.31 team: accessibility type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WCAG: Skip links trigger dynamic search on the page

2 participants