Skip to content

Add resource fields to integration schema specs#14358

Merged
andreslucena merged 4 commits intofeature/api-improvementfrom
feature/api/integration
Mar 20, 2025
Merged

Add resource fields to integration schema specs#14358
andreslucena merged 4 commits intofeature/api-improvementfrom
feature/api/integration

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu commented Mar 19, 2025

🎩 What? Why?

This PR adds some more fields to the intagration specs

📌 Related Issues

Link your PR to an issue

  • Related to #?
  • Fixes #?

Testing

Describe the best way to test or validate your PR.

📷 Screenshots

Please add screenshots of the changes you are proposing
Description

♥️ Thank you!

@alecslupu alecslupu added graphql-api Affects the GraphQL API project: 2024-api Barcelona Supercomputing Center contract labels Mar 19, 2025
@alecslupu alecslupu marked this pull request as ready for review March 20, 2025 05:23
@alecslupu alecslupu requested a review from andreslucena March 20, 2025 05:23
@@ -10,6 +10,8 @@
fragment fooComponent on Blogs {
post(id: #{post.id}) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change this query so it is alphabetically (as it was before)? It's much easier to read that way

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in 7c7ad42

@@ -150,6 +155,8 @@
edges {
node{
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in 7c7ad42

@alecslupu alecslupu requested a review from andreslucena March 20, 2025 10:40
@andreslucena andreslucena changed the title Add resource fields to integration_schema specs Add resource fields to integration schema specs Mar 20, 2025
@alecslupu alecslupu requested a review from andreslucena March 20, 2025 13:10
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I'm happy with how this looks like. Thanks for your patience!

@andreslucena andreslucena merged commit fdf3061 into feature/api-improvement Mar 20, 2025
44 of 45 checks passed
@andreslucena andreslucena deleted the feature/api/integration branch March 20, 2025 14:20
andreslucena added a commit that referenced this pull request Mar 28, 2025
* Update of the API GraphQL

* Refactor api

* Running linters

* Update decidim-core/lib/decidim/api/interfaces/attachable_collection_interface.rb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Update `decidim-blogs` GraphQL API (#14327)

* Update `decidim-blogs` GraphQL API

* Add url to list

* Update `decidim-debates` GraphQL API (#14331)

* Update `decidim-debates` GraphQL API

* Refactor specs

* Add more fields

* Update `decidim-budgets` GraphQL API (#14328)

* Update `decidim-budgets` GraphQL API

* Add more fields

* Apply suggestions from code review

* Add budget integration specs

* Update decidim-budgets/spec/types/project_type_spec.rb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Sort alphabetically

---------

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Update `decidim-accountability` GraphQL API (#14326)

* Change Api for Accountability module

* Fix spec

* Add url field

* Add proposal urls field

* Add integration_spec for results

* Sort alphabetically

* More

* More sorting

* Update `decidim-conferences` GraphQL API (#14330)

* Update `decidim-conferences` GraphQL API

* Running linters

* Add more fields

* Fix usage

* Add url spec

* Implement conference schema spec

* Sort alphabetically

* Add resource fields to integration schema specs (#14358)

* Add post fields to integration_schema spec

* Add debate fields to integration_schema spec

* Sort alphabetically

* Sort alphabetically

* Update `decidim-assemblies` GraphQL API (#14329)

* Update `decidim-assemblies` GraphQL API

* Fixing specs

* Add url to assemblies

* Fix spec

* Add integration specs

* Sort alphabetically

---------

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

graphql-api Affects the GraphQL API module: blogs module: debates project: 2024-api Barcelona Supercomputing Center contract

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants