Update decidim-accountability GraphQL API#14326
Merged
andreslucena merged 10 commits intofeature/api-improvementfrom Mar 20, 2025
Merged
Update decidim-accountability GraphQL API#14326andreslucena merged 10 commits intofeature/api-improvementfrom
decidim-accountability GraphQL API#14326andreslucena merged 10 commits intofeature/api-improvementfrom
Conversation
04f1b74 to
56bf0e7
Compare
56bf0e7 to
04502a1
Compare
decidim-accountability GraphQL API
…into feature/api/accountability
andreslucena
requested changes
Mar 19, 2025
| field :parent, Decidim::Accountability::ResultType, "The parent result", null: true | ||
| field :progress, GraphQL::Types::Float, "The progress for this result", null: true | ||
| field :reference, GraphQL::Types::String, "The reference for this result", null: true | ||
| field :proposal_urls, [String, { null: true }], "The proposal URLs for this result", null: true |
Member
There was a problem hiding this comment.
On this case we could just return the ProposalType, right? I think it'd be more idiomatic, as if we just return the URL, then the consumers of the API need to make another query for getting the metadata of the Proposals by getting the ID/component/process/etc.
Does that makes sense?
| progress | ||
| reference | ||
| startDate | ||
| address |
Member
There was a problem hiding this comment.
please follow alphabetical order 😄
andreslucena
approved these changes
Mar 20, 2025
andreslucena
added a commit
that referenced
this pull request
Mar 28, 2025
* Update of the API GraphQL * Refactor api * Running linters * Update decidim-core/lib/decidim/api/interfaces/attachable_collection_interface.rb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Update `decidim-blogs` GraphQL API (#14327) * Update `decidim-blogs` GraphQL API * Add url to list * Update `decidim-debates` GraphQL API (#14331) * Update `decidim-debates` GraphQL API * Refactor specs * Add more fields * Update `decidim-budgets` GraphQL API (#14328) * Update `decidim-budgets` GraphQL API * Add more fields * Apply suggestions from code review * Add budget integration specs * Update decidim-budgets/spec/types/project_type_spec.rb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Sort alphabetically --------- Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Update `decidim-accountability` GraphQL API (#14326) * Change Api for Accountability module * Fix spec * Add url field * Add proposal urls field * Add integration_spec for results * Sort alphabetically * More * More sorting * Update `decidim-conferences` GraphQL API (#14330) * Update `decidim-conferences` GraphQL API * Running linters * Add more fields * Fix usage * Add url spec * Implement conference schema spec * Sort alphabetically * Add resource fields to integration schema specs (#14358) * Add post fields to integration_schema spec * Add debate fields to integration_schema spec * Sort alphabetically * Sort alphabetically * Update `decidim-assemblies` GraphQL API (#14329) * Update `decidim-assemblies` GraphQL API * Fixing specs * Add url to assemblies * Fix spec * Add integration specs * Sort alphabetically --------- Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR we review the
accountabilitymodule, to which :📌 Related Issues
Link your PR to an issue
Testing
Describe the best way to test or validate your PR.
📷 Screenshots
Please add screenshots of the changes you are proposing
