Skip to content

Update DownloadYourData exports for decidim-meetings#13959

Merged
alecslupu merged 11 commits intodevelopfrom
feature/download-your-data/meetings
Jan 30, 2025
Merged

Update DownloadYourData exports for decidim-meetings#13959
alecslupu merged 11 commits intodevelopfrom
feature/download-your-data/meetings

Conversation

@andreslucena
Copy link
Copy Markdown
Member

🎩 What? Why?

This PR updates the DownloadYourData exports for decidim-meetings models.

On this case what I'm doing is:

📌 Related Issues

Testing

  • Everything should be green
  • There shouldn't be new fields to add here

♥️ Thank you!

github-actions[bot]
github-actions bot previously approved these changes Jan 28, 2025
github-actions[bot]
github-actions bot previously approved these changes Jan 29, 2025
github-actions[bot]
github-actions bot previously approved these changes Jan 29, 2025
github-actions[bot]
github-actions bot previously approved these changes Jan 29, 2025
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost perfect.
I would change a bit the decidim-meetings/lib/decidim/meetings/meeting_serializer.rb to remove the initializer and resource alias.

@andreslucena
Copy link
Copy Markdown
Member Author

Almost perfect. I would change a bit the decidim-meetings/lib/decidim/meetings/meeting_serializer.rb to remove the initializer and resource alias.

Done at faa5129

Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

LGTM

@alecslupu alecslupu merged commit ba8f484 into develop Jan 30, 2025
@alecslupu alecslupu deleted the feature/download-your-data/meetings branch January 30, 2025 19:07
antopalidi pushed a commit to openpoke/decidim that referenced this pull request Feb 12, 2025
Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
andreslucena added a commit that referenced this pull request Mar 3, 2025
Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants