Skip to content

Manage uploaded census records in the admin panel#13850

Merged
alecslupu merged 66 commits intodevelopfrom
feature/manage_upload_census_records
Apr 9, 2025
Merged

Manage uploaded census records in the admin panel#13850
alecslupu merged 66 commits intodevelopfrom
feature/manage_upload_census_records

Conversation

@ElviaBth
Copy link
Copy Markdown
Contributor

@ElviaBth ElviaBth commented Jan 14, 2025

🎩 What? Why?

Display and manage uploaded census records in the admin panel.

📌 Related Issues

Testing

📷 Screenshots

image
index view
image
import census view
image
add new census record view
image
edit record view

♥️ Thank you!

Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['type: feature', 'type: change', 'type: fix', 'type: removal', 'target: developer-experience', 'type: internal']

@request-info
Copy link
Copy Markdown

request-info bot commented Jan 14, 2025

It seems like you did not give us much information about what you are trying to do here. We would appreciate it if you could provide us with more info about this issue/PR!

github-actions[bot]
github-actions bot previously approved these changes Jan 14, 2025
github-actions[bot]
github-actions bot previously approved these changes Jan 14, 2025
github-actions[bot]
github-actions bot previously approved these changes Jan 14, 2025
github-actions[bot]
github-actions bot previously approved these changes Jan 15, 2025
github-actions[bot]
github-actions bot previously approved these changes Jan 15, 2025
github-actions[bot]
github-actions bot previously approved these changes Jan 15, 2025
github-actions[bot]
github-actions bot previously approved these changes Jan 16, 2025
github-actions[bot]
github-actions bot previously approved these changes Jan 16, 2025
github-actions[bot]
github-actions bot previously approved these changes Apr 7, 2025
github-actions[bot]
github-actions bot previously approved these changes Apr 7, 2025
github-actions[bot]
github-actions bot previously approved these changes Apr 7, 2025
github-actions[bot]
github-actions bot previously approved these changes Apr 7, 2025
Copy link
Copy Markdown
Contributor

@microstudi microstudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is improving, we still need to refine it a bit.
Check the comments!

github-actions[bot]
github-actions bot previously approved these changes Apr 8, 2025
github-actions[bot]
github-actions bot previously approved these changes Apr 8, 2025
github-actions[bot]
github-actions bot previously approved these changes Apr 9, 2025
github-actions[bot]
github-actions bot previously approved these changes Apr 9, 2025
@ElviaBth
Copy link
Copy Markdown
Contributor Author

ElviaBth commented Apr 9, 2025

I have reviewed like 24 out of 35 files and i have some functionality issues that are not in the initial change request, also i have a little different approach on the matter :

  • There is no log to clearly state ( "Admin imported %{count} Census records"
  • When I edit, create or update the census record, i get a generic message "%{admin} created", "%{admin} updated", "%{admin} deleted" ... but i do not know why.
  • GDPR wise, seeing all those emails & verification info in plain view I would say is not pretty ( maybe @decidim/product may see it otherwise )

Hi @alecslupu. This PR is ready for a re-check.

Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended, I would revert the changes on decidim-proposals/spec/system/filter_proposals_spec.rb

Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended. Will merge to develop as soon the pipeline becomes green.

If it fails, i will merge with latest develop as soon the proposal flaky specs are merged ( #14442, #14474 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display and manage uploaded census records in the admin panel

6 participants