Remove user tooltips in the application#14442
Merged
andreslucena merged 14 commits intodevelopfrom Apr 24, 2025
Merged
Conversation
Member
|
|
greenwoodt
reviewed
Apr 17, 2025
Member
greenwoodt
left a comment
There was a problem hiding this comment.
Pipeline is green and so far no errors. I can still see some references to the Tooltip in the codebase like: decidim-core/app/packs/stylesheets/decidim/_tooltip.scss.
If I understand right this is temporary removal until we have another solution?
Contributor
Author
This PR aims to remove just the author tooltip. The CSS stays behind as it is generic, and may be used for other things as well. |
andreslucena
requested changes
Apr 22, 2025
Member
andreslucena
left a comment
There was a problem hiding this comment.
I think we should drop the SCSS too:
diff --git a/decidim-core/app/packs/stylesheets/decidim/_author.scss b/decidim-core/app/packs/stylesheets/decidim/_author.scss
index c9d59d256d..abeb8051ed 100644
--- a/decidim-core/app/packs/stylesheets/decidim/_author.scss
+++ b/decidim-core/app/packs/stylesheets/decidim/_author.scss
@@ -37,27 +37,6 @@
}
}
- &__tooltip {
- @apply grid grid-cols-[1fr_max-content] gap-6 odd:[&>*]:place-self-start even:[&>*]:place-self-end z-50;
-
- /* overwrite default styles */
- &[role="tooltip"] {
- @apply max-w-max;
- }
-
- &-links {
- @apply flex flex-col items-end justify-evenly h-full whitespace-nowrap text-sm hover:[&>*]:underline;
- }
- }
-
- &__tooltip &__avatar-container {
- @apply w-10 h-10 border-2 border-white hover:border-tertiary;
- }
-
- &__tooltip &__name {
- @apply text-white text-lg font-bold hover:underline;
- }
-
&__coauthors {
@apply flex flex-wrap items-center gap-2;Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR is disabling user tooltips, as it generated some flaky specs in the pipeline.
During a telegram discussion with maintainer's chat, we agreed to temporary remove the support for this functionality, until we have a better solution / approach to it.
Also, it has some inconsistent way of working that could be traced back to 0.29.2. The tooltips are generated when the app is loading firs time, but then, in proposal will disappear when trying to change the listing from list to grid, or sorting by other criterias or even filtering.
Fixes: #14431
Testing: