Fix flaky spec on proposal filters#14474
Merged
Conversation
776f2f9 to
7ae552c
Compare
4e503db to
e0101d1
Compare
andreslucena
approved these changes
Apr 10, 2025
Member
andreslucena
left a comment
There was a problem hiding this comment.
I can confirm that this is working locally with the provided script for reproducing it.
My intuition is that this failure is related to the complexity of this particular context. Is the one with more code (185) and has lots of before blocks. As I don't time to provide an alternative for now, this is good enough for fixing the failure that we were seeing lately.
Contributor
Author
|
merging with codecov failing pipeline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR fixes a flaky spec on proposal filters.
Testing
Describe the best way to test or validate your PR.