Skip to content

Update open data exports for Debates#13698

Merged
andreslucena merged 21 commits intodecidim:developfrom
greenwoodt:change/csv-exports-debates
Dec 9, 2024
Merged

Update open data exports for Debates#13698
andreslucena merged 21 commits intodecidim:developfrom
greenwoodt:change/csv-exports-debates

Conversation

@greenwoodt
Copy link
Copy Markdown
Member

@greenwoodt greenwoodt commented Nov 27, 2024

🎩 What? Why?

Update of columns for the csv_export of the Debates component. This is a part of on going work in Ref: MGOV06

As images have not been added yet, its been left out of the serializer. PR: #13521 has more information.

📌 Related Issues

Testing

  1. Load the branch locally
  2. rebuild the development_app
  3. Launch app locally to the browser
  4. Head to the footer and find & click the "Open Data" link
  5. Download Debates CSV
  6. See newly added columns

run decidim-debates/spec/lib/decidim/debates/debate_serializer_spec.rb

📷 Screenshots

♥️ Thank you!

@greenwoodt greenwoodt added module: debates type: change PRs that implement a change for an existing feature project: 2024-flatfiles Metagov grant labels Nov 27, 2024
github-actions[bot]
github-actions bot previously approved these changes Nov 27, 2024
github-actions[bot]
github-actions bot previously approved these changes Nov 27, 2024
github-actions[bot]
github-actions bot previously approved these changes Nov 27, 2024
github-actions[bot]
github-actions bot previously approved these changes Nov 28, 2024
github-actions[bot]
github-actions bot previously approved these changes Nov 28, 2024
@greenwoodt greenwoodt marked this pull request as ready for review November 28, 2024 16:32
github-actions[bot]
github-actions bot previously approved these changes Nov 28, 2024
github-actions[bot]
github-actions bot previously approved these changes Nov 28, 2024
github-actions[bot]
github-actions bot previously approved these changes Nov 28, 2024
@andreslucena andreslucena changed the title Update Open Data exports for Debates Update open data exports for Debates Dec 2, 2024
@andreslucena
Copy link
Copy Markdown
Member

Also there are some relevant failing sepcs, please check that out too

greenwoodt and others added 2 commits December 3, 2024 17:42
github-actions[bot]
github-actions bot previously approved these changes Dec 3, 2024
github-actions[bot]
github-actions bot previously approved these changes Dec 3, 2024
github-actions[bot]
github-actions bot previously approved these changes Dec 4, 2024
github-actions[bot]
github-actions bot previously approved these changes Dec 4, 2024
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@andreslucena andreslucena merged commit ccf5c6f into decidim:develop Dec 9, 2024
antopalidi pushed a commit that referenced this pull request Dec 16, 2024
* updated and created (including specs) added

* added followers and the test for them

* added translations for debates

* normalize the tansalations

* followers_count removed as followers already added

* test to check closed_at when is false

* added comments author type and last comment id

* fixed updated_at test

* last_id and last_type refined

* updated transaltions

* renamed the followers count method

* added endorsements count and test

* endorsements_count updated translation

* Update decidim-debates/lib/decidim/debates/debate_serializer.rb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* updated spec for follows count

* logic created to retrieve values if a comment is left on a debate

* tests for last comment fields if comments are left on debate and test for no values

* removed unused i18n translations

* updated translations of last_comment_by ans follows_count

* renamed author name and url to reflect user

---------

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: debates project: 2024-flatfiles Metagov grant type: change PRs that implement a change for an existing feature

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants