Merged
Conversation
carolromero
requested changes
Oct 18, 2024
Member
There was a problem hiding this comment.
@antopalidi here's the feedback from the review, only a couple things to adjust:
- On the frontend side: the button to add/edit documents should look the same as the one in the proposals form, and use the same help text as well:
Debates:
Proposals:
- On the admin side, use the same text as in proposal setting:
Thanks!
alecslupu
suggested changes
Dec 6, 2024
Contributor
alecslupu
left a comment
There was a problem hiding this comment.
I was reviewing this, and i think we missing something . Could you have a look ?
decidim-debates/app/commands/decidim/debates/admin/update_debate.rb
Outdated
Show resolved
Hide resolved
…te.rb Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This pull request introduces the ability to attach files when creating or editing debates. The proposed feature enables file attachments for debates, both from the admin panel and the frontend, improving the flexibility and functionality of debates within the platform.
📌 Related Issues
Testing
As an admin, go to the admin panel and configure a Debate component.
As a participant, try to create or edit a debate from the frontend.
Test file type and size validation by uploading files that either exceed the configured limits or are of unsupported types, ensuring the system shows appropriate error messages.
📷 Screenshots