Skip to content

Show extended information when a new comment is in a digest email#12563

Merged
alecslupu merged 3 commits intodevelopfrom
fix/comment-text-missing-digest-notifications
Mar 12, 2024
Merged

Show extended information when a new comment is in a digest email#12563
alecslupu merged 3 commits intodevelopfrom
fix/comment-text-missing-digest-notifications

Conversation

@andreslucena
Copy link
Copy Markdown
Member

🎩 What? Why?

When having the digest email for notifications and there's activity with comments, you get always the same notification. I saw this the past week with some activity in Metadecidim:

Screenshot of the digest email with the bug
Screenshot of the digest email with the bug (part 2)

This PR fixes that by adding the comment body to these emails.

📌 Related Issues

Testing

  1. Sign in as admin@example.org
  2. Follow a participatory process
  3. In another browser, sign in as user@example.org
  4. Go to the same participatory process
  5. Create a comment in a proposal
  6. Go to http://localhost:3000/rails/mailers/decidim/notifications_digest_mailer/digest_mail and see the notification with the comment body

📷 Screenshots

Screenshot of the notification with the comment body

♥️ Thank you!

Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['type: feature', 'type: change', 'type: fix', 'type: removal', 'target: developer-experience', 'type: internal']

@andreslucena andreslucena added module: core type: fix PRs that implement a fix for a bug labels Mar 6, 2024
github-actions[bot]
github-actions bot previously approved these changes Mar 6, 2024
@andreslucena
Copy link
Copy Markdown
Member Author

Failing spec is fixed with #12566
This is ready for a review

@andreslucena andreslucena marked this pull request as ready for review March 6, 2024 08:22
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreslucena , i have tried to check this PR, but i think you forgot to attach the preview mailer class.

When trying to verify the reproduction steps, i could not access the preview class due to error.
image

@andreslucena
Copy link
Copy Markdown
Member Author

@andreslucena , i have tried to check this PR, but i think you forgot to attach the preview mailer class.

Oopsie, I've added it in 8eed44d

Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The HTML version is displaying correctly. On the text version in multiple mailers we have an arrow --> that seems that an html comment may have been wrongly truncated. ( not in scope of this PR )

image

@alecslupu
Copy link
Copy Markdown
Contributor

@andreslucena , can you merge with the latest develop so that we validate there is no issue with the pipeline ?

@andreslucena
Copy link
Copy Markdown
Member Author

@andreslucena , can you merge with the latest develop so that we validate there is no issue with the pipeline ?

Done in 60932cc, everything is green 💚

@alecslupu alecslupu merged commit d1c3f16 into develop Mar 12, 2024
@alecslupu alecslupu deleted the fix/comment-text-missing-digest-notifications branch March 12, 2024 12:00
andreslucena added a commit that referenced this pull request May 9, 2024
…2563)

* Show extended information when a new comment is in a digest email

* Add newsletter preview mailer class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: core type: fix PRs that implement a fix for a bug

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

Comment text missing in email digest notifications

2 participants