Skip to content

Remove duplication for ParticipatorySpace User examples#11578

Merged
andreslucena merged 1 commit intodevelopfrom
refactor/admin-participatory-space-user-specs
Sep 12, 2023
Merged

Remove duplication for ParticipatorySpace User examples#11578
andreslucena merged 1 commit intodevelopfrom
refactor/admin-participatory-space-user-specs

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu commented Sep 9, 2023

🎩 What? Why?

CodeClimate found that there was some duplication in the "filterable participatory space user roles" spec example. This PR refactors it so it's no longer duplicated.

📌 Related Issues

Link your PR to an issue

Testing

All the CI should be green

📷 Screenshots

image

♥️ Thank you!

@alecslupu alecslupu force-pushed the refactor/admin-participatory-space-user-specs branch from cd14884 to 6d03c22 Compare September 9, 2023 05:45
@alecslupu alecslupu added module: admin target:cleanup type: removal PRs that implement a removal of a functionality or code labels Sep 9, 2023
@alecslupu alecslupu requested a review from a team September 9, 2023 05:46
@alecslupu alecslupu marked this pull request as ready for review September 9, 2023 07:11
andreslucena
andreslucena approved these changes Sep 12, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

Gif of a cheff kiss

@andreslucena andreslucena merged commit a4dfcf5 into develop Sep 12, 2023
@andreslucena andreslucena deleted the refactor/admin-participatory-space-user-specs branch September 12, 2023 09:14
entantoencuanto added a commit that referenced this pull request Sep 12, 2023
@entantoencuanto
Merge branch 'develop' into feature/redesign-admin
96d8c85 
* develop:
  Enable identical and similar code statements in CodeClimate configuration (#10383)
  Fix flaky spec for mobile version of the search form (#11558)
  Remove duplication for ParticipatorySpace User examples (#11578)
  Add title in arrows while navigating meetings (#11574)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreslucena andreslucena andreslucena approved these changes

Assignees

No one assigned

Labels

module: admin target:cleanup type: removal PRs that implement a removal of a functionality or code

Projects

No open projects
Maintainers' backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alecslupu @andreslucena