Skip to content

Add title in arrows while navigating meetings#11574

Merged
alecslupu merged 2 commits intodevelopfrom
fix/design-hover-meetings-arrows
Sep 12, 2023
Merged

Add title in arrows while navigating meetings#11574
alecslupu merged 2 commits intodevelopfrom
fix/design-hover-meetings-arrows

Conversation

@andreslucena
Copy link
Copy Markdown
Member

🎩 What? Why?

Arrows navigation in Meetings don't have any kind of help. This PR adds a title for these icons so it's visible while hovering.

📌 Related Issues

Testing

  1. Go to a meeting
  2. Hover in these arrows

📷 Screenshots

Screenshot of the arrow hovered with the title "previous item"

♥️ Thank you!

@andreslucena andreslucena added module: meetings type: fix PRs that implement a fix for a bug project: redesign Barcelona City Council contract no-backport Pull Requests that should not be backported labels Sep 8, 2023
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:
image
image

Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreslucena The code looks ok, but it seems that we need to normalize the locales, and after that, we are good to go.

@alecslupu alecslupu self-assigned this Sep 11, 2023
Suggested by code review

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alecslupu alecslupu merged commit 8b5f1a8 into develop Sep 12, 2023
@alecslupu alecslupu deleted the fix/design-hover-meetings-arrows branch September 12, 2023 06:30
entantoencuanto added a commit that referenced this pull request Sep 12, 2023
* develop:
  Enable identical and similar code statements in CodeClimate configuration (#10383)
  Fix flaky spec for mobile version of the search form (#11558)
  Remove duplication for ParticipatorySpace User examples (#11578)
  Add title in arrows while navigating meetings (#11574)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: meetings no-backport Pull Requests that should not be backported project: redesign Barcelona City Council contract type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Arrows when navigating meetings

2 participants