Merged
Conversation
53fbfde to
c2905f8
Compare
c2905f8 to
a0f4d36
Compare
Contributor
Author
|
|
…cesses, assemblies and participatory process groups
…atory processes and assemblies
a0f4d36 to
fc520d5
Compare
ferblape
previously approved these changes
Jul 18, 2023
Contributor
ferblape
left a comment
There was a problem hiding this comment.
Code looks ok to me, I just lack a bit of documentation, that maybe could be included in the CHANGELOG.
Let's see what @decidim/maintainers suggest
Contributor
|
While reviewing this, i have noticed the homepage Meetings widget that actually has a empty height. ( maybe #11102 ) |
alecslupu
suggested changes
Jul 18, 2023
Contributor
alecslupu
left a comment
There was a problem hiding this comment.
Please make sure that you add the task documentation to the 3. One time actions section within RELEASE_NOTES.
alecslupu
reviewed
Jul 24, 2023
alecslupu
suggested changes
Jul 24, 2023
Contributor
alecslupu
left a comment
There was a problem hiding this comment.
Let's fix the linting errors.
Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
alecslupu
approved these changes
Jul 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

🎩 What? Why?
This PR:
participatory_processes,assembliesorparticipatory_process_group) and also the id of an instance of their models can be specifiedNOTE
This PR depends on #10931 which implements association between participatory process group and content blocks via resource manifest. Once merged this PR the failing tests should pass
📌 Related Issues
Link your PR to an issue
Testing
Describe the best way to test or validate your PR.
📷 Screenshots
Please add screenshots of the changes you are proposing
