Skip to content

Redesign: content blocks tasks#11109

Merged
alecslupu merged 10 commits intodevelopfrom
feature/redesign-content-blocks-tasks
Jul 24, 2023
Merged

Redesign: content blocks tasks#11109
alecslupu merged 10 commits intodevelopfrom
feature/redesign-content-blocks-tasks

Conversation

@entantoencuanto
Copy link
Copy Markdown
Contributor

@entantoencuanto entantoencuanto commented Jun 30, 2023

🎩 What? Why?

This PR:

  • Defines a service to generate content blocks for landing pages of organizations, processes, assemblies or groups of processes
  • Uses the service in the create_default_content_blocks command called in the organization creation
  • Uses the service in the creation commands of processes, assemblies or groups of processes
  • Defines a task to create default content blocks on existing processes, assemblies and groups of processes and optionally create content blocks associated to published components (this option only applies to processes and assemblies). The task can be called for a specific type of space using its space or resource manifest name (participatory_processes, assemblies or participatory_process_group) and also the id of an instance of their models can be specified
  • Fixes a bug on extra_data participatory process group content block that occurs when the associated data is empty

NOTE

This PR depends on #10931 which implements association between participatory process group and content blocks via resource manifest. Once merged this PR the failing tests should pass

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

📷 Screenshots

Please add screenshots of the changes you are proposing
Description

♥️ Thank you!

@entantoencuanto entantoencuanto added the project: redesign Barcelona City Council contract label Jun 30, 2023
@entantoencuanto entantoencuanto force-pushed the feature/redesign-content-blocks-tasks branch from 53fbfde to c2905f8 Compare July 3, 2023 09:07
Base automatically changed from feature/redesign to develop July 10, 2023 09:13
@alecslupu
Copy link
Copy Markdown
Contributor

The following commits needs to be cherry picked:

#11109
14fa771
a326da6
6b19641
3d29f87
9f4d608
ae999a1
d636db3
c2905f8

@entantoencuanto entantoencuanto force-pushed the feature/redesign-content-blocks-tasks branch from c2905f8 to a0f4d36 Compare July 13, 2023 11:36
@entantoencuanto entantoencuanto marked this pull request as ready for review July 17, 2023 09:14
@entantoencuanto
Copy link
Copy Markdown
Contributor Author

entantoencuanto commented Jul 17, 2023

Some tests are failing in the elections module which is not redesigned yet in this PR. The tests should pass after merging #10804

@entantoencuanto entantoencuanto force-pushed the feature/redesign-content-blocks-tasks branch from a0f4d36 to fc520d5 Compare July 17, 2023 09:17
@ferblape ferblape self-requested a review July 18, 2023 06:23
ferblape
ferblape previously approved these changes Jul 18, 2023
Copy link
Copy Markdown
Contributor

@ferblape ferblape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks ok to me, I just lack a bit of documentation, that maybe could be included in the CHANGELOG.

Let's see what @decidim/maintainers suggest

@ferblape ferblape requested a review from a team July 18, 2023 07:18
@alecslupu
Copy link
Copy Markdown
Contributor

While reviewing this, i have noticed the homepage Meetings widget that actually has a empty height. ( maybe #11102 )

image

Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure that you add the task documentation to the 3. One time actions section within RELEASE_NOTES.

Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix the linting errors.

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
@alecslupu alecslupu merged commit 39d92d9 into develop Jul 24, 2023
@alecslupu alecslupu deleted the feature/redesign-content-blocks-tasks branch July 24, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

project: redesign Barcelona City Council contract

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Redesign / Rake task to create content blocks of a space when an instance is upgraded Define initial content blocks when a process is created

5 participants