Skip to content

Redesign: elections & votings#10804

Merged
alecslupu merged 162 commits intodevelopfrom
feature/redesign-elections
Jul 20, 2023
Merged

Redesign: elections & votings#10804
alecslupu merged 162 commits intodevelopfrom
feature/redesign-elections

Conversation

@Crashillo
Copy link
Copy Markdown
Contributor

@Crashillo Crashillo commented Apr 28, 2023 •
edited
Loading

🎩 What? Why?

Redesign the election component within a participatory space.

Pending
  • Nav links

📷 Screenshots

♥️ Thank you!

@Crashillo Crashillo added the project: redesign Barcelona City Council contract label Apr 28, 2023
@Crashillo Crashillo force-pushed the feature/redesign-elections branch 2 times, most recently from 0f57e7e to 00a646c Compare May 12, 2023 14:59
@Crashillo Crashillo force-pushed the feature/redesign-elections branch from 0dd07fc to fa95e07 Compare May 22, 2023 16:09
@andreslucena andreslucena mentioned this pull request May 31, 2023
Merged
@Crashillo Crashillo force-pushed the feature/redesign-elections branch 2 times, most recently from 58f856f to ad55e1e Compare July 6, 2023 14:04
@Crashillo Crashillo changed the title Redesign: elections Redesign: elections & votings Jul 7, 2023
Base automatically changed from feature/redesign to develop July 10, 2023 09:13
@alecslupu
Copy link
Copy Markdown
Contributor

alecslupu commented Jul 10, 2023

Considering the conflicts, The following commits needs to be cherrypicked to make sure the PR is ok:

#10804
b45db3c
802878e
bd890d7
b64cf80
2169298
abb3bc4
0192439
c64a699
7088bca
a5aace7
9d5dba8
8da7a3b
031c536
c4fce38
956782a
00a646c
e857752
0e8def4
8e54547
2ff0b5b
772f9a0
711e7b0
fa95e07
fb9ff32
f304083
49c034a
19e3133
1fbfa50
54edd89
0f0e615
2d5c05a
7534900
3d1ada2
43cb69a
64dbd65
d2cdbb7
b938101
fcd1db5
dafb922
d9ae566
12957ce
625a1a0
97d1343
c8d8f3a
4bd4ba9
c22121f
340897e
6dc48e4
6d58fd3
592c394
74738fa
282a8c7
5e4562f
2a8e913
9aec5c2
9ce9435
477868c
caef8db
455e30a
2e537f7
9c8fd88
2f51446
ad55e1e
c9626fc
c53a6b4
f3887f1
e8731e6
2cd4c38
b3f93a5
622b613
51e4004
27f4375
6c07824
8410c30
d232693
b5a3b21
a764b4c
e30af5a
5062461

@Crashillo Crashillo linked an issue Jul 10, 2023 that may be closed by this pull request
Redesign: Cards L&G for votings #10480
Closed
@ferblape ferblape requested a review from alecslupu July 18, 2023 08:15
@alecslupu
Copy link
Copy Markdown
Contributor

alecslupu commented Jul 18, 2023

Clicking on "Ask for a new one " lead to a 404 page when the voting is not present.
image

@alecslupu
Copy link
Copy Markdown
Contributor

alecslupu commented Jul 18, 2023

On the Voting homepage, a Giant box is shown for each election. Scroll the image:
image

@alecslupu
Copy link
Copy Markdown
Contributor

alecslupu commented Jul 18, 2023

Also The DOB field from voting screen vs Can i vote screen has a different behavior. In the Voting screen, once i fill in the date the cursor skip automatically to month, then year, whereas in the Can i vote screen, i need to manually switch fields using mouse or tab:

image

alecslupu
alecslupu suggested changes Jul 18, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inspecting the voting process (I could not pass over the access code / voting code), i have found 3 elements that do not work properly.

cc @decidim/product @furilo @ferblape

@Crashillo
Copy link
Copy Markdown
Contributor Author

Crashillo commented Jul 19, 2023

Clicking on "Ask for a new one " lead to a 404 page when the voting is not present.

We're trying to reproduce the error but we cannot find it out. Could you please share an url? Anyways, the anchor link (voting_check_census_path) has not changed, so I assume this is an uncatched exception already present in develop.

@alecslupu
Copy link
Copy Markdown
Contributor

alecslupu commented Jul 19, 2023

Clicking on "Ask for a new one " lead to a 404 page when the voting is not present.

We're trying to reproduce the error but we cannot find it out. Could you please share an url? Anyways, the anchor link (voting_check_census_path) has not changed, so I assume this is an uncatched exception already present in develop.

I will need to check, but i think i was in the preview mode for an election, case when that link is available and leads to a 404 ..

@Crashillo Crashillo requested a review from alecslupu July 19, 2023 12:35
@alecslupu
Copy link
Copy Markdown
Contributor

alecslupu commented Jul 19, 2023

Clicking on "Ask for a new one " lead to a 404 page when the voting is not present.

We're trying to reproduce the error but we cannot find it out. Could you please share an url? Anyways, the anchor link (voting_check_census_path) has not changed, so I assume this is an uncatched exception already present in develop.

I will need to check, but i think i was in the preview mode for an election, case when that link is available and leads to a 404 ..

OK, i have a reproductibile pattern here:

  1. Load the database seeds on localhost
  2. visit votings ( actually access the Highlight votings )
  3. scroll down to Elections
  4. Select One that is "Active"
  5. Click "Start Voting"
  6. See the "Ask for a new one" that is pointing to a 404 page.

@Crashillo @alecslupu
Update decidim-elections/app/views/decidim/votings/votings/_check_fie…
71266cd 
…lds.html.erb

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
alecslupu
alecslupu approved these changes Jul 20, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alecslupu alecslupu merged commit 91198ec into develop Jul 20, 2023
@alecslupu alecslupu deleted the feature/redesign-elections branch July 20, 2023 11:44
@Crashillo Crashillo restored the feature/redesign-elections branch July 28, 2023 09:45
@Crashillo Crashillo deleted the feature/redesign-elections branch July 28, 2023 09:46
@alecslupu alecslupu mentioned this pull request Jul 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@ferblape ferblape Awaiting requested review from ferblape

@furilo furilo Awaiting requested review from furilo

@andreslucena andreslucena Awaiting requested review from andreslucena

+2 more reviewers

@entantoencuanto entantoencuanto entantoencuanto left review comments

@alecslupu alecslupu alecslupu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

project: redesign Barcelona City Council contract

Projects

No open projects
PX Redesign
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Redesign: Cards L&G for votings

7 participants

@Crashillo @alecslupu @ferblape @entantoencuanto @andreslucena @github-advanced-security @furilo