Skip to content

Add spelling check script for the CI#10553

Merged
alecslupu merged 27 commits intodecidim:developfrom
mainio:chore/spelling-check
Mar 16, 2023
Merged

Add spelling check script for the CI#10553
alecslupu merged 27 commits intodecidim:developfrom
mainio:chore/spelling-check

Conversation

@andreslucena
Copy link
Copy Markdown
Member

Oh I really like this approach 👏🏽.

IMHO separating the configuration from the script itself is 🔝

I haven't tried it yet, but let me know when its ready to be reviewed and I'll give it an spin.

@ahukkanen
Copy link
Copy Markdown
Contributor Author

ahukkanen commented Mar 15, 2023

@andreslucena I think this is now otherwise ready but I will still wait for #10557 to be merged before marking this ready for review.

To fix the CI in this PR as it is broken right now. But meanwhile it also gives you a chance to see this in action at the current state of the PR as there are some annotations added at the "Files" tab of this PR right now.

EDIT: It has been now merged and the CI is therefore passing in this PR.

@ahukkanen
Copy link
Copy Markdown
Contributor Author

@andreslucena I've applied the suggestions from shellcheck and disabled the SC2002 rule (useless cat) as it's incorrect. The cat there is not useless (see e96c46f).

@ahukkanen ahukkanen requested a review from andreslucena March 16, 2023 17:21
@alecslupu alecslupu merged commit cbc587e into decidim:develop Mar 16, 2023
@ahukkanen ahukkanen deleted the chore/spelling-check branch March 16, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

target: developer-experience type: internal PRs that aren't necessary to add to the CHANGELOG for implementers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants