Valuator should not access resource moderation tools (hide button)#10205
Merged
andreslucena merged 13 commits intodecidim:developfrom Apr 25, 2023
Merged
Valuator should not access resource moderation tools (hide button)#10205andreslucena merged 13 commits intodecidim:developfrom
andreslucena merged 13 commits intodecidim:developfrom
Conversation
Member
|
Can we retake this PR @alecslupu 🙏🏽 ? You'd need to merge with develop just to be sure, as its an older PR. Thanks |
Contributor
Author
|
Yes, is on the list to make it happen. I just want to focus on what is hot, so that we actually close them :) |
Contributor
Author
|
@andreslucena This has been rataken, you could start the review process when time suits you. |
andreslucena
requested changes
Apr 20, 2023
Member
andreslucena
left a comment
There was a problem hiding this comment.
I tried this out locally and work as advertised.
Just a quick refactor to make it cleaner and we're good to go on my side
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
During the review and testing of #10024, @ahukkanen noticed that process valuators can also see the hiding controls.
@decidim/product has confirmed that the valuators should not be able to see the moderations tools.
This PR addesses the issue.
📌 Related Issues
Link your PR to an issue
Testing
Please note: This PR should not be backported to older releases.
♥️ Thank you!