Fix flaky test_workspace_concurrency#5690
Merged
Conversation
7482b79 to
abbe850
Compare
Collaborator
Author
|
All test failures are unrelated; ready for review and merge |
fjetter
approved these changes
Jan 25, 2022
Member
fjetter
left a comment
There was a problem hiding this comment.
This test has been haunting us for too long. I'm a bit shocked about the slowness on windows side but don't think it is worth investigating. Thank you for looking into this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed special mp_context treatment for Windows and Pypy. I ran a quick hello world in pypy and forkserver seems to work fine. In either case, the default is spawn, so only those users that explicitly set otherwise in the config should be affected. As a general rule, silently ignoring users' decisions is bad policy.
test_workspace_concurrency_intense#4766