Change default multiprocessing behavior to spawn#3461
Merged
mrocklin merged 2 commits intodask:masterfrom Feb 12, 2020
Merged
Conversation
Member
Author
|
I genuinely don't understand why the asyncio.sleep avoids the broken pipe error messages, but it does. |
6d7621e to
81a5a72
Compare
Member
|
Thanks Matt! This seems like a good change to me. 😄 Should we make an analogous change to Dask? |
Member
Author
I'm just doing this in response to user issues. I don't currently have any thoughts on what to do with dask proper. My understanding is that it isn't currently a problem, so I plan to ignore it for now. |
Member
Author
|
Saw this test failure ___________________________ test_tcp_connect_timeout ___________________________
@pytest.mark.asyncio
async def test_tcp_connect_timeout():
> await check_connect_timeout("tcp://127.0.0.1:44444")
distributed/comm/tests/test_comms.py:841:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
addr = 'tcp://127.0.0.1:44444'
async def check_connect_timeout(addr):
t1 = time()
with pytest.raises(IOError):
> await connect(addr, timeout=0.15)
E Failed: DID NOT RAISE <class 'OSError'>
distributed/comm/tests/test_comms.py:834: Failed |
Member
Author
|
OK, I'm going to go ahead and merge this for now. I suspect that we'll get a couple of new intermittent test failures for a bit due to the increased testing time, but it seems nicer than the alternative. cc @bnaul |
This was referenced Apr 24, 2020
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3374