Merged
Conversation
Contributor
|
It seems that the unit tests in msgpack-python use a different approach to the issue of tuples. See, e.g. lbolla/msgpack-python@c8042ea |
Collaborator
|
I like the approach in that and we can implement set, tuple, frozenset which is probably good enough for now? Implemented it in #2003 |
Member
Author
|
Do we need to move sets with msgpack? Do we need to move anything other
than tuples?
…On Wed, May 23, 2018 at 9:39 PM, Marius van Niekerk < ***@***.***> wrote:
I like the approach in that and we can implement set, tuple, frozenset
which is probably good enough for now?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2000 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AASszJcSxQsQuvlPzOTdDAcCwUD0XE7_ks5t1g9IgaJpZM4UKY97>
.
|
Collaborator
|
I've fixed some of the failing tests here in a branch of mine. Whats the easiest way to add those commits |
Member
Author
|
Because I'm somewhat occupied this week the best solution might be to
submit a PR of your own to the master branch, possibly including my
commits or not, as you like. You could also submit a PR to my PR's branch.
…On Tue, May 29, 2018 at 12:19 PM, Marius van Niekerk < ***@***.***> wrote:
I've fixed some of the failing tests here in a branch of mine. Whats the
easiest way to add those commits
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2000 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AASszGuMRd8u65o7-HHXZ1rC_OftLP7mks5t3XUAgaJpZM4UKY97>
.
|
Member
Author
|
OK, hypothetically this passes tests. There are some things that concern me though:
I would not be surprised if this came back to bite us later. |
Member
Author
|
Well, lets see what happens. Merging. |
This was referenced Apr 16, 2020
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes msgpack decode arrays as tuples rather than lists, allowing them to be used within containers like set and dict that expect hashable elements.
cc @mariusvniekerk
I took a quick look at this but then got side tracked by other things. I thought I'd push it up here in case you were interested in carrying on.