[wip] Use ext types with msgpack to move tuples, sets and frozensets nicely#2003
[wip] Use ext types with msgpack to move tuples, sets and frozensets nicely#2003mariusvniekerk wants to merge 4 commits intodask:masterfrom
Conversation
|
This is cool, however I worry slightly about going outside of the standard msgpack spec. Hypothetically systems in other languages should be able to talk to the scheduler and workers over msgpack. The more complex we make things here the harder that becomes. I'm inclined to keep things as close to stock as possible if there is no strong need otherwise. Do we have strong need to move around sets and frozensets? |
|
So clients that don't implement special handling for these types will receive an ext_type which is part of the spec, which is just (code, msgpackabe-payload), If we make that payload looks a bit nicer say something like |
|
One other problematic area here is we lose the ability to serialize defaultdict and ordereddict without some additional work, which is kinda silly |
|
Perhaps we first try the approach in #2000 and see if it suffices? If so then we call it a day? Things like defaultdicts are, I think, entirely out of scope for how we use msgpack. I think that it's important to keep in mind that we only use msgpack here to serialize administrative messages. We shouldn't need that much variety when using it. |
|
Yep, lets try that (also the test failures here are from serializing defaultdicts :P ) |
|
OK to close this @mariusvniekerk ? |
Alternate to #2000