Test `exp` with CuPy arrays by jakirkham · Pull Request #7322 · dask/dask

jakirkham · 2021-03-04T19:01:38Z

Closes #xxxx
Tests added / passed
Passes black dask / flake8 dask

xref: dask/dask-image#133 (comment)

cc @GenevieveBuckley @pentschev

pentschev

Thanks @jakirkham ! 😄

jrbourbeau

Just to confirm, does this test pass? (I don't have a GPU locally)

jakirkham · 2021-03-04T19:41:43Z

Yes here's the results from running this test on a DGX-1

Details

$ git log -n1
commit c6bbaf11273b843ef59e56fd7999344439a1b814 (HEAD)
Author: John Kirkham <jakirkham@gmail.com>
Date:   Thu Mar 4 11:00:20 2021 -0800

    Test `exp` with CuPy arrays
$ python -m pytest -k test_basic dask/array/tests/test_cupy.py 
============================= test session starts ==============================
platform linux -- Python 3.8.6, pytest-6.2.2, py-1.10.0, pluggy-0.13.1 -- /datasets/jkirkham/miniconda/envs/rapids17dev/bin/python
cachedir: .pytest_cache
rootdir: /datasets/jkirkham/devel/dask, configfile: setup.cfg
collected 182 items / 123 deselected / 59 selected                             

dask/array/tests/test_cupy.py::test_basic[<lambda>0] PASSED              [  1%]
dask/array/tests/test_cupy.py::test_basic[<lambda>1] PASSED              [  3%]
dask/array/tests/test_cupy.py::test_basic[<lambda>2] PASSED              [  5%]
dask/array/tests/test_cupy.py::test_basic[<lambda>3] PASSED              [  6%]
dask/array/tests/test_cupy.py::test_basic[<lambda>4] PASSED              [  8%]
dask/array/tests/test_cupy.py::test_basic[<lambda>5] PASSED              [ 10%]
dask/array/tests/test_cupy.py::test_basic[<lambda>6] PASSED              [ 11%]
dask/array/tests/test_cupy.py::test_basic[<lambda>7] PASSED              [ 13%]
dask/array/tests/test_cupy.py::test_basic[<lambda>8] PASSED              [ 15%]
dask/array/tests/test_cupy.py::test_basic[<lambda>9] PASSED              [ 16%]
dask/array/tests/test_cupy.py::test_basic[<lambda>10] PASSED             [ 18%]
dask/array/tests/test_cupy.py::test_basic[<lambda>11] PASSED             [ 20%]
dask/array/tests/test_cupy.py::test_basic[<lambda>12] PASSED             [ 22%]
dask/array/tests/test_cupy.py::test_basic[<lambda>13] PASSED             [ 23%]
dask/array/tests/test_cupy.py::test_basic[<lambda>14] PASSED             [ 25%]
dask/array/tests/test_cupy.py::test_basic[<lambda>15] PASSED             [ 27%]
dask/array/tests/test_cupy.py::test_basic[<lambda>16] PASSED             [ 28%]
dask/array/tests/test_cupy.py::test_basic[<lambda>17] PASSED             [ 30%]
dask/array/tests/test_cupy.py::test_basic[<lambda>18] PASSED             [ 32%]
dask/array/tests/test_cupy.py::test_basic[<lambda>19] PASSED             [ 33%]
dask/array/tests/test_cupy.py::test_basic[<lambda>20] PASSED             [ 35%]
dask/array/tests/test_cupy.py::test_basic[<lambda>21] PASSED             [ 37%]
dask/array/tests/test_cupy.py::test_basic[<lambda>22] XFAIL (cupy.do...) [ 38%]
dask/array/tests/test_cupy.py::test_basic[<lambda>23] XFAIL (cupy.do...) [ 40%]
dask/array/tests/test_cupy.py::test_basic[<lambda>24] XFAIL (cupy.do...) [ 42%]
dask/array/tests/test_cupy.py::test_basic[<lambda>25] PASSED             [ 44%]
dask/array/tests/test_cupy.py::test_basic[<lambda>26] PASSED             [ 45%]
dask/array/tests/test_cupy.py::test_basic[<lambda>27] PASSED             [ 47%]
dask/array/tests/test_cupy.py::test_basic[<lambda>28] PASSED             [ 49%]
dask/array/tests/test_cupy.py::test_basic[<lambda>29] PASSED             [ 50%]
dask/array/tests/test_cupy.py::test_basic[<lambda>30] PASSED             [ 52%]
dask/array/tests/test_cupy.py::test_basic[<lambda>31] PASSED             [ 54%]
dask/array/tests/test_cupy.py::test_basic[<lambda>32] PASSED             [ 55%]
dask/array/tests/test_cupy.py::test_basic[<lambda>33] PASSED             [ 57%]
dask/array/tests/test_cupy.py::test_basic[<lambda>34] PASSED             [ 59%]
dask/array/tests/test_cupy.py::test_basic[<lambda>35] PASSED             [ 61%]
dask/array/tests/test_cupy.py::test_basic[<lambda>36] PASSED             [ 62%]
dask/array/tests/test_cupy.py::test_basic[<lambda>37] PASSED             [ 64%]
dask/array/tests/test_cupy.py::test_basic[<lambda>38] PASSED             [ 66%]
dask/array/tests/test_cupy.py::test_basic[<lambda>39] PASSED             [ 67%]
dask/array/tests/test_cupy.py::test_basic[<lambda>40] PASSED             [ 69%]
dask/array/tests/test_cupy.py::test_basic[<lambda>41] PASSED             [ 71%]
dask/array/tests/test_cupy.py::test_basic[<lambda>42] PASSED             [ 72%]
dask/array/tests/test_cupy.py::test_basic[<lambda>43] PASSED             [ 74%]
dask/array/tests/test_cupy.py::test_basic[<lambda>44] PASSED             [ 76%]
dask/array/tests/test_cupy.py::test_basic[<lambda>45] PASSED             [ 77%]
dask/array/tests/test_cupy.py::test_basic[<lambda>46] PASSED             [ 79%]
dask/array/tests/test_cupy.py::test_basic[<lambda>47] PASSED             [ 81%]
dask/array/tests/test_cupy.py::test_basic[<lambda>48] PASSED             [ 83%]
dask/array/tests/test_cupy.py::test_basic[<lambda>49] PASSED             [ 84%]
dask/array/tests/test_cupy.py::test_basic[<lambda>50] PASSED             [ 86%]
dask/array/tests/test_cupy.py::test_basic[<lambda>51] PASSED             [ 88%]
dask/array/tests/test_cupy.py::test_basic[<lambda>52] PASSED             [ 89%]
dask/array/tests/test_cupy.py::test_basic[<lambda>53] PASSED             [ 91%]
dask/array/tests/test_cupy.py::test_basic[<lambda>54] PASSED             [ 93%]
dask/array/tests/test_cupy.py::test_basic[<lambda>55] PASSED             [ 94%]
dask/array/tests/test_cupy.py::test_basic[<lambda>56] PASSED             [ 96%]
dask/array/tests/test_cupy.py::test_basic[<lambda>57] PASSED             [ 98%]
dask/array/tests/test_cupy.py::test_basic[<lambda>58] PASSED             [100%]

============================= slowest 10 durations =============================
0.25s call     dask/array/tests/test_cupy.py::test_basic[<lambda>38]
0.06s call     dask/array/tests/test_cupy.py::test_basic[<lambda>19]
0.04s call     dask/array/tests/test_cupy.py::test_basic[<lambda>0]
0.03s call     dask/array/tests/test_cupy.py::test_basic[<lambda>57]
0.03s call     dask/array/tests/test_cupy.py::test_basic[<lambda>53]
0.03s call     dask/array/tests/test_cupy.py::test_basic[<lambda>20]
0.02s call     dask/array/tests/test_cupy.py::test_basic[<lambda>13]
0.02s call     dask/array/tests/test_cupy.py::test_basic[<lambda>54]
0.02s call     dask/array/tests/test_cupy.py::test_basic[<lambda>12]
0.02s call     dask/array/tests/test_cupy.py::test_basic[<lambda>21]
=========================== short test summary info ============================
XFAIL dask/array/tests/test_cupy.py::test_basic[<lambda>22]
  cupy.dot(numpy) fails
XFAIL dask/array/tests/test_cupy.py::test_basic[<lambda>23]
  cupy.dot(numpy) fails
XFAIL dask/array/tests/test_cupy.py::test_basic[<lambda>24]
  cupy.dot(numpy) fails
================ 56 passed, 123 deselected, 3 xfailed in 2.87s =================

jrbourbeau

Great, thanks @jakirkham!

jakirkham · 2021-03-04T20:24:36Z

Thanks James! 😄

* upstream/master: (43 commits) bump version to 2021.03.0 Bump minimum version of distributed (dask#7328) Fix `percentiles_summary` with `dask_cudf` (dask#7325) Temporarily revert recent Array.__setitem__ updates (dask#7326) Blockwise.clone (dask#7312) NEP-35 duck array update (dask#7321) Don't allow setting `.name` for array (dask#7222) Use nearest interpolation for creating percentiles of integer input (dask#7305) Test `exp` with CuPy arrays (dask#7322) Check that computed chunks have right size and dtype (dask#7277) pytest.mark.flaky (dask#7319) Contributing docs: add note to pull the latest git tags before pip installing Dask (dask#7308) Support for Python 3.9 (dask#7289) Add broadcast-based merge implementation (dask#7143) Add split_every to graph_manipulation (dask#7282) Typo in optimize docs (dask#7306) dask.graph_manipulation support for xarray.Dataset (dask#7276) Add plot width and height support for Bokeh 2.3.0 (dask#7297) Add numpy functions tri, triu_indices, triu_indices_from, tril_indices, tril_indices_from (dask#6997) Remove "cleanup" task in dataframe on-disk shuffle. The partd directory (dask#7260) ...

Test exp with CuPy arrays

c6bbaf1

jakirkham mentioned this pull request Mar 4, 2021

GPU Support dask/dask-image#133

Open

pentschev approved these changes Mar 4, 2021

View reviewed changes

jrbourbeau reviewed Mar 4, 2021

View reviewed changes

jrbourbeau approved these changes Mar 4, 2021

View reviewed changes

jrbourbeau merged commit c66926f into dask:master Mar 4, 2021

jakirkham deleted the tst_cupy_exp branch March 4, 2021 20:24

dependabot bot mentioned this pull request Mar 8, 2021

Update dask requirement from ^2020.12.0 to ^2021.3.0 Kwonil-Kim/kkpy#8

Closed

dependabot bot mentioned this pull request Mar 12, 2021

Bump dask[bag] from 2.24.0 to 2021.3.0 admdev8/pyglotaran#52

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Test `exp` with CuPy arrays#7322

Test `exp` with CuPy arrays#7322
jrbourbeau merged 1 commit intodask:masterfrom
jakirkham:tst_cupy_exp

jakirkham commented Mar 4, 2021

Uh oh!

pentschev left a comment

Uh oh!

jrbourbeau left a comment

Uh oh!

jakirkham commented Mar 4, 2021

Uh oh!

jrbourbeau left a comment

Uh oh!

jakirkham commented Mar 4, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

jakirkham commented Mar 4, 2021

Uh oh!

pentschev left a comment

Choose a reason for hiding this comment

Uh oh!

jrbourbeau left a comment

Choose a reason for hiding this comment

Uh oh!

jakirkham commented Mar 4, 2021

Uh oh!

jrbourbeau left a comment

Choose a reason for hiding this comment

Uh oh!

jakirkham commented Mar 4, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants