Skip to content

Support for Python 3.9#7289

Merged
jrbourbeau merged 10 commits intodask:masterfrom
crusaderky:python39
Mar 3, 2021
Merged

Support for Python 3.9#7289
jrbourbeau merged 10 commits intodask:masterfrom
crusaderky:python39

Conversation

@crusaderky
Copy link
Collaborator

@crusaderky crusaderky commented Feb 28, 2021

Note: numba support for Python 3.9 is already available in numba-0.53rc2 on the numba channel; however it contains a regression that causes our tests to fail: numba/numba#6773

@crusaderky
Copy link
Collaborator Author

crusaderky commented Mar 1, 2021

I'm getting issues on parallel pytest on MacOS.
[EDIT] it's a numpy ordering issue

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great to see, thanks for your work on this (and the corresponding PR in distributed).

Comment on lines +8 to +9
- numpy
- pandas
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We tend to use the different Python version builds to also test against different versions of NumPy and pandas. Could you pin NumPy and pandas for this build to be something between the Python 3.7 and 3.9 builds?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm planning to shift all versions in the PR where I drop python 3.6

@crusaderky
Copy link
Collaborator Author

The current situation is that Python 3.9 on Windows is unstable. I had

  • a C-level stack overflow on an unspecified test
  • an interpreter crash on a trivial test that should trigger a RecursionError

the two things are likely related. I'm going to try and reproduce on my local windows machine.

Everything else is good to go.

@crusaderky
Copy link
Collaborator Author

The issue in Windows was caused by ipython, which causes the interpreter to crash instead of raising RecursionError: ipython/ipython#12197

@crusaderky
Copy link
Collaborator Author

@jrbourbeau @mrocklin Both PRs are ready for review and merge.
The latest round of tests will fail as I just reverted to distributed@master.
Good tests visible as of the previous commit https://github.com/dask/dask/runs/2013590328

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @crusaderky! This looks great

@jrbourbeau jrbourbeau merged commit 3e39e6b into dask:master Mar 3, 2021
@crusaderky crusaderky deleted the python39 branch March 4, 2021 10:43
dcherian added a commit to dcherian/dask that referenced this pull request Mar 8, 2021
* upstream/master: (43 commits)
  bump version to 2021.03.0
  Bump minimum version of distributed (dask#7328)
  Fix `percentiles_summary` with `dask_cudf` (dask#7325)
  Temporarily revert recent Array.__setitem__ updates (dask#7326)
  Blockwise.clone (dask#7312)
  NEP-35 duck array update (dask#7321)
  Don't allow setting `.name` for array (dask#7222)
  Use nearest interpolation for creating percentiles of integer input (dask#7305)
  Test `exp` with CuPy arrays (dask#7322)
  Check that computed chunks have right size and dtype (dask#7277)
  pytest.mark.flaky (dask#7319)
  Contributing docs: add note to pull the latest git tags before pip installing Dask (dask#7308)
  Support for Python 3.9 (dask#7289)
  Add broadcast-based merge implementation (dask#7143)
  Add split_every to graph_manipulation (dask#7282)
  Typo in optimize docs (dask#7306)
  dask.graph_manipulation support for xarray.Dataset (dask#7276)
  Add plot width and height support for Bokeh 2.3.0 (dask#7297)
  Add numpy functions tri, triu_indices, triu_indices_from, tril_indices, tril_indices_from (dask#6997)
  Remove "cleanup" task in dataframe on-disk shuffle. The partd directory (dask#7260)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants