Prepare Blockwise + IO infrastructure#7281
Merged
jrbourbeau merged 121 commits intodask:mainfrom Mar 12, 2021
Merged
Conversation
…void duplicating the same kwargs for every output partition
…er for row-wise filtering
crusaderky
reviewed
Mar 2, 2021
Member
Author
|
Thanks you for the review @crusaderky - Your comments/suggestions are very valuable! I am still unsure about the current |
rjzamora
commented
Mar 2, 2021
ian-r-rose
reviewed
Mar 4, 2021
jrbourbeau
reviewed
Mar 4, 2021
Member
Author
|
Oops - looks like #7312 just added a new |
ian-r-rose
reviewed
Mar 9, 2021
Member
Author
|
@madsbk - Not sure if you have time for a quick look here, but your thoughts are very welcome. I am hoping to get this merged very soon :) |
jrbourbeau
approved these changes
Mar 12, 2021
Member
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks for your patience on this PR @rjzamora, this is in
douglasdavis
pushed a commit
to douglasdavis/dask
that referenced
this pull request
Mar 14, 2021
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an optional prerequisite for #7042. In other words, this includes a small subset of the changes introduced in that PR, and is intended to simplify the review process.
Changes included here:
io_depsinput/attribute to aBlockwiselayer. This attribute is needed to materialize a collections within aBlockwiselayer (i.e. IO).dask.array'szeros,ones, andfullover toBlockwise.zeros,ones, andfull.