Fix io_deps bug in rewrite_blockwise#6989
Conversation
|
cc @dcherian - I'm hoping this is the only fix needed for the xarray CI failures. Please do let me know if you already have a simple dask.array test handy :) |
|
I confirmed that xarray's CI passes on this branch locally. I could not create a pure |
I also tried to create a test, and found it really challenging! The xarray test has some very subtle things going on with null checks in a string array that I wasn't able to untangle. |
|
Yes it's breaking on
|
|
Closing in favor of #7042 |
Addresses xarray#4703 (which is alse described in #6931 )
The current
rewrite_blockwisecode is updating a list of IO-dependencies (io_deps) within a loop that can be escaped before all dependencies are collected. This is causing CI errors in xarray. This PR moves theio_depsupdate to a simple/dedicated loop over all input layers.TODO: