Fixes for svd with __array_function__#6727
Merged
TomAugspurger merged 3 commits intodask:masterfrom Oct 12, 2020
Merged
Conversation
2 tasks
Member
Author
|
Failure seems completely unrelated to this PR, any ideas about the origin for the error? |
Member
|
Agreed that the failure looks unrelated. I haven't seen that failure before and I wasn't able to reproduce it locally. |
Member
|
Oh, I take that back. When repeating the test 500 times I did eventually get a failure. I didn't have Anyway, I'll take a look at it separately. |
TomAugspurger
approved these changes
Oct 12, 2020
Closed
Member
Author
|
Thanks @TomAugspurger for checking and merging! |
kumarprabhu1988
pushed a commit
to kumarprabhu1988/dask
that referenced
this pull request
Oct 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a couple of small issues that were introduced with
__array_function__-only cases in the works of #6616 and #6623 .