Backend-aware dtype inference for single-chunk svd#6623
Merged
TomAugspurger merged 1 commit intodask:masterfrom Sep 11, 2020
Merged
Backend-aware dtype inference for single-chunk svd#6623TomAugspurger merged 1 commit intodask:masterfrom
TomAugspurger merged 1 commit intodask:masterfrom
Conversation
Member
|
Thanks! |
Member
|
Somehow I missed this PR. There was a small issue with this and another with #6616 that are now being fixed in #6727 . Thanks for the work on improving SVD consistency @eric-czech ! |
kumarprabhu1988
pushed a commit
to kumarprabhu1988/dask
that referenced
this pull request
Oct 29, 2020
Co-authored-by: Eric Czech <eric@related.vc>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
black dask/flake8 daskThis is a follow-up from #6616 (comment).
As @pentschev and @TomAugspurger suggested, this will run svd using a tiny, non-empty array via whatever backend the given dask array is already wrapping. I only needed this to get the dtypes for the results, and I assume the semantics for the result types could be different for numpy/cupy so this seems like the clearest way to ensure that the dtype passed to
from_delayedaccurately reflects what would come out of any svd function dispatched to from np.linalg.svd.