Don't use exception hooks to shorten tracebacks [1/2]#10456
Merged
crusaderky merged 2 commits intodask:mainfrom Aug 24, 2023
Merged
Don't use exception hooks to shorten tracebacks [1/2]#10456crusaderky merged 2 commits intodask:mainfrom
crusaderky merged 2 commits intodask:mainfrom
Conversation
47d2fc9 to
479ff18
Compare
2f0a15a to
1ef22b7
Compare
Co-authored-by: Hendrik Makait <hendrik@makait.com>
jrbourbeau
added a commit
that referenced
this pull request
Aug 28, 2023
This reverts commit 709e977.
crusaderky
added a commit
to crusaderky/dask
that referenced
this pull request
Aug 29, 2023
…dask#10456)"" This reverts commit 7572987.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove interpreter-level exception hooks.
Reattach hooks explicitly to
dask.computedask.persist(dask collection).compute(dask collection).persistThe latter two display a single spurious frame, which I decided to leave there for the sake of simplicity.
dask/distributed#8127 is the twin PR in distributed to reinsert the cleanup in
distributed.Future.resultdistributed.Future.__await__distributed.Client.gatherCC @jrbourbeau