Skip to content

Don't use exception hooks to shorten tracebacks [2/2]#8127

Merged
crusaderky merged 5 commits intodask:mainfrom
crusaderky:ipdb_except_hook
Aug 24, 2023
Merged

Don't use exception hooks to shorten tracebacks [2/2]#8127
crusaderky merged 5 commits intodask:mainfrom
crusaderky:ipdb_except_hook

Conversation

@crusaderky
Copy link
Copy Markdown
Collaborator

@crusaderky crusaderky commented Aug 23, 2023

This has a material impact only on synchronous Client.gather().
Future.result() (sync and async) and async Client.gather() already had a short traceback; this PR just does a bit of code cleanup.

@crusaderky crusaderky mentioned this pull request Aug 23, 2023
Merged
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 23, 2023 •
edited
Loading

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       21 files  +       1         21 suites  +1   11h 10m 39s ⏱️ - 20m 38s
  3 783 tests +       4    3 674 ✔️ +       8     107 💤 ±  0  2 ❌  - 4 
36 559 runs  +1 413  34 753 ✔️ +1 381  1 804 💤 +38  2 ❌  - 6 

For more details on these failures, see this check.

Results for commit 1390b83. ± Comparison against base commit 22eb33a.

This pull request removes 1 and adds 5 tests. Note that renamed tests count towards both. 
distributed.tests.test_client ‑ test_short_tracebacks

distributed.tests.test_client ‑ test_short_tracebacks[gather]
distributed.tests.test_client ‑ test_short_tracebacks[result]
distributed.tests.test_client ‑ test_short_tracebacks_async[await]
distributed.tests.test_client ‑ test_short_tracebacks_async[gather]
distributed.tests.test_client ‑ test_short_tracebacks_async[result]

♻️ This comment has been updated with latest results.

@crusaderky
Revert "TEMP CI change"
c13d088 
This reverts commit b84fd0f.
@crusaderky crusaderky self-assigned this Aug 24, 2023
@crusaderky crusaderky marked this pull request as ready for review August 24, 2023 11:22
@crusaderky crusaderky requested a review from fjetter as a code owner August 24, 2023 11:22
@crusaderky
Copy link
Copy Markdown
Collaborator Author

crusaderky commented Aug 24, 2023

CI is all green; tests evidence vs dask/dask#10456 is here: https://github.com/dask/distributed/actions/runs/5953348968/job/16147390855

hendrikmakait
hendrikmakait approved these changes Aug 24, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@hendrikmakait hendrikmakait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @crusaderky!

@crusaderky crusaderky merged commit a057190 into dask:main Aug 24, 2023
@crusaderky crusaderky deleted the ipdb_except_hook branch August 24, 2023 17:38
This was referenced Aug 29, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hendrikmakait hendrikmakait hendrikmakait approved these changes

@fjetter fjetter Awaiting requested review from fjetter fjetter is a code owner

Assignees

@crusaderky crusaderky

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Importing dask breaks ipython's %pdb command

2 participants

@crusaderky @hendrikmakait