Merge #18181: test: Remove incorrect assumptions in validation_flush_tests #4536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_flush_tests faca8ef test: Remove incorrect assumptions in validation_flush_tests (MarcoFalke) fa31eeb test: Tabs to spaces in all tests (MarcoFalke) Pull request description: The tests assume standard library internals that may not hold on all supported archs or when the code is instrumented for sanitizer or debug use cases Fixes bitcoin#18111 ACKs for top commit: jamesob: ACK bitcoin@faca8ef pending passing tests fjahr: ACK faca8ef Tree-SHA512: 60a5ae824bdffb0762f82f67957b31b185385900be5e676fcb12c23d53f5eea734601680c2e3f0bdb8052ce90e7ca1911b1342affb67e43d91a506b111406f41 # Conflicts: # src/test/validation_flush_tests.cpp
pravblockc
pushed a commit
to pravblockc/dash
that referenced
this pull request
Nov 18, 2021
…_flush_tests (dashpay#4536) faca8ef test: Remove incorrect assumptions in validation_flush_tests (MarcoFalke) fa31eeb test: Tabs to spaces in all tests (MarcoFalke) Pull request description: The tests assume standard library internals that may not hold on all supported archs or when the code is instrumented for sanitizer or debug use cases Fixes bitcoin#18111 ACKs for top commit: jamesob: ACK bitcoin@faca8ef pending passing tests fjahr: ACK faca8ef Tree-SHA512: 60a5ae824bdffb0762f82f67957b31b185385900be5e676fcb12c23d53f5eea734601680c2e3f0bdb8052ce90e7ca1911b1342affb67e43d91a506b111406f41 # Conflicts: # src/test/validation_flush_tests.cpp Co-authored-by: MarcoFalke <falke.marco@gmail.com>
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Nov 10, 2023
…_flush_tests (dashpay#4536) faca8ef test: Remove incorrect assumptions in validation_flush_tests (MarcoFalke) fa31eeb test: Tabs to spaces in all tests (MarcoFalke) Pull request description: The tests assume standard library internals that may not hold on all supported archs or when the code is instrumented for sanitizer or debug use cases Fixes bitcoin#18111 ACKs for top commit: jamesob: ACK bitcoin@faca8ef pending passing tests fjahr: ACK faca8ef Tree-SHA512: 60a5ae824bdffb0762f82f67957b31b185385900be5e676fcb12c23d53f5eea734601680c2e3f0bdb8052ce90e7ca1911b1342affb67e43d91a506b111406f41 # Conflicts: # src/test/validation_flush_tests.cpp Co-authored-by: MarcoFalke <falke.marco@gmail.com>
gades
pushed a commit
to piratecash/pirate
that referenced
this pull request
Dec 9, 2023
…_flush_tests (dashpay#4536) faca8ef test: Remove incorrect assumptions in validation_flush_tests (MarcoFalke) fa31eeb test: Tabs to spaces in all tests (MarcoFalke) Pull request description: The tests assume standard library internals that may not hold on all supported archs or when the code is instrumented for sanitizer or debug use cases Fixes bitcoin#18111 ACKs for top commit: jamesob: ACK bitcoin@faca8ef pending passing tests fjahr: ACK faca8ef Tree-SHA512: 60a5ae824bdffb0762f82f67957b31b185385900be5e676fcb12c23d53f5eea734601680c2e3f0bdb8052ce90e7ca1911b1342affb67e43d91a506b111406f41 # Conflicts: # src/test/validation_flush_tests.cpp Co-authored-by: MarcoFalke <falke.marco@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a unit test failure on develop on certain architectures. (which includes mine)
Introduced in #4498 / 16945