test: Remove incorrect assumptions in validation_flush_tests #18181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fa79631 to
fa74f56
Compare
fa74f56 to
fab9b8c
Compare
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
added 2 commits
February 19, 2020 11:51
Spaces are used in all of the source code except in these two instances
fab9b8c to
faca8ef
Compare
Contributor
|
ACK faca8ef pending passing tests |
Member
Author
Contributor
|
ACK faca8ef Reviewed code, tests pass. |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Feb 22, 2020
…_flush_tests faca8ef test: Remove incorrect assumptions in validation_flush_tests (MarcoFalke) fa31eeb test: Tabs to spaces in all tests (MarcoFalke) Pull request description: The tests assume standard library internals that may not hold on all supported archs or when the code is instrumented for sanitizer or debug use cases Fixes bitcoin#18111 ACKs for top commit: jamesob: ACK bitcoin@faca8ef pending passing tests fjahr: ACK faca8ef Tree-SHA512: 60a5ae824bdffb0762f82f67957b31b185385900be5e676fcb12c23d53f5eea734601680c2e3f0bdb8052ce90e7ca1911b1342affb67e43d91a506b111406f41
sidhujag
pushed a commit
to syscoin-core/syscoin
that referenced
this pull request
Nov 10, 2020
…_flush_tests faca8ef test: Remove incorrect assumptions in validation_flush_tests (MarcoFalke) fa31eeb test: Tabs to spaces in all tests (MarcoFalke) Pull request description: The tests assume standard library internals that may not hold on all supported archs or when the code is instrumented for sanitizer or debug use cases Fixes bitcoin#18111 ACKs for top commit: jamesob: ACK bitcoin@faca8ef pending passing tests fjahr: ACK faca8ef Tree-SHA512: 60a5ae824bdffb0762f82f67957b31b185385900be5e676fcb12c23d53f5eea734601680c2e3f0bdb8052ce90e7ca1911b1342affb67e43d91a506b111406f41
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jan 18, 2021
…SizeState [plus fix] Summary: Core [[bitcoin/bitcoin#16945 | PR16945]] 02b9511d6bace5711e454d2b685b2fee0d65e341 tests: add tests for GetCoinsCacheSizeState (James O'Beirne) b17e91d842724d2888a179a73585cc4c2ef1dc21 refactoring: introduce CChainState::GetCoinsCacheSizeState (James O'Beirne) Pull request description: This is part of the [assumeutxo project](https://github.com/bitcoin/bitcoin/projects/11): Parent PR: #15606 Issue: #15605 Specification: https://github.com/jamesob/assumeutxo-docs/tree/master/proposal This pulls out the routine for detection of how full the coins cache is from FlushStateToDisk. We use this logic independently when deciding when to flush the coins cache during UTXO snapshot activation ([see here](bitcoin/bitcoin@231fb5f#diff-24efdb00bfbe56b140fb006b562cc70bR5275)). --- Core [[bitcoin/bitcoin#18181 | PR18181]] faca8eff39876cc8c0ee609a89bdcebc21976d47 test: Remove incorrect assumptions in validation_flush_tests (MarcoFalke) fa31eebfe9107e14dc1d6b588f5b4c878d1010de test: Tabs to spaces in all tests (MarcoFalke) Pull request description: The tests assume standard library internals that may not hold on all supported archs or when the code is instrumented for sanitizer or debug use cases Fixes #18111 --- Backport of Core [[bitcoin/bitcoin#16945 | PR16945]] and [[bitcoin/bitcoin#18181 | PR18181]] (the fix in [[bitcoin/bitcoin#18181 | PR18181]] is contained to test/validation_flush_tests.cpp) Test Plan: ninja all check check-functional Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D8938
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Oct 23, 2021
…_flush_tests faca8ef test: Remove incorrect assumptions in validation_flush_tests (MarcoFalke) fa31eeb test: Tabs to spaces in all tests (MarcoFalke) Pull request description: The tests assume standard library internals that may not hold on all supported archs or when the code is instrumented for sanitizer or debug use cases Fixes bitcoin#18111 ACKs for top commit: jamesob: ACK bitcoin@faca8ef pending passing tests fjahr: ACK faca8ef Tree-SHA512: 60a5ae824bdffb0762f82f67957b31b185385900be5e676fcb12c23d53f5eea734601680c2e3f0bdb8052ce90e7ca1911b1342affb67e43d91a506b111406f41 # Conflicts: # src/test/validation_flush_tests.cpp
UdjinM6
pushed a commit
to dashpay/dash
that referenced
this pull request
Oct 24, 2021
…_flush_tests (#4536) faca8ef test: Remove incorrect assumptions in validation_flush_tests (MarcoFalke) fa31eeb test: Tabs to spaces in all tests (MarcoFalke) Pull request description: The tests assume standard library internals that may not hold on all supported archs or when the code is instrumented for sanitizer or debug use cases Fixes bitcoin#18111 ACKs for top commit: jamesob: ACK bitcoin@faca8ef pending passing tests fjahr: ACK faca8ef Tree-SHA512: 60a5ae824bdffb0762f82f67957b31b185385900be5e676fcb12c23d53f5eea734601680c2e3f0bdb8052ce90e7ca1911b1342affb67e43d91a506b111406f41 # Conflicts: # src/test/validation_flush_tests.cpp Co-authored-by: MarcoFalke <falke.marco@gmail.com>
pravblockc
pushed a commit
to pravblockc/dash
that referenced
this pull request
Nov 18, 2021
…_flush_tests (dashpay#4536) faca8ef test: Remove incorrect assumptions in validation_flush_tests (MarcoFalke) fa31eeb test: Tabs to spaces in all tests (MarcoFalke) Pull request description: The tests assume standard library internals that may not hold on all supported archs or when the code is instrumented for sanitizer or debug use cases Fixes bitcoin#18111 ACKs for top commit: jamesob: ACK bitcoin@faca8ef pending passing tests fjahr: ACK faca8ef Tree-SHA512: 60a5ae824bdffb0762f82f67957b31b185385900be5e676fcb12c23d53f5eea734601680c2e3f0bdb8052ce90e7ca1911b1342affb67e43d91a506b111406f41 # Conflicts: # src/test/validation_flush_tests.cpp Co-authored-by: MarcoFalke <falke.marco@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests assume standard library internals that may not hold on all supported archs or when the code is instrumented for sanitizer or debug use cases
Fixes #18111