Skip to content

print starknetstaking envs#2335

Merged
pablomendezroyo merged 4 commits intopablo/allow-setting-starknet-envsfrom
marc/get-starknet-envs
Dec 23, 2025
Merged

print starknetstaking envs#2335
pablomendezroyo merged 4 commits intopablo/allow-setting-starknet-envsfrom
marc/get-starknet-envs

Conversation

@Marketen
Copy link
Copy Markdown
Contributor

@Marketen Marketen commented Dec 22, 2025

Backend: Starknet staking environment support

  • Added methods getStarknetOperationalAddresses and getStarknetSignerPrivateKey to the Consensus class to retrieve the Starknet signer operational address and private key from package environment variables. These are now included in the result of getAllConsensus for Starknet networks. [1] [2]
  • Updated the StakerComponent.getAll method and the StakerItemBasic type to accept and propagate the new Starknet-specific fields (starknetSignerOperationalAddress, starknetSignerPrivateKey). [1] [2] [3]

Frontend: Improved credential visibility and UX

  • Updated the Starknet full node form to use the current operational address as the placeholder for the address field, and to display a masked placeholder (asterisks) for the private key if it exists, improving clarity for users. [1] [2]

Minor cleanup

  • Removed a console log from useStarknetConfig when loading starknet UI. It was printing privkey in plaintext in console

@Marketen Marketen requested a review from a team as a code owner December 22, 2025 09:28
@github-actions github-actions bot temporarily deployed to commit December 22, 2025 09:29 Inactive
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 22, 2025

@github-actions github-actions bot temporarily deployed to commit December 22, 2025 10:10 Inactive
@github-actions github-actions bot temporarily deployed to commit December 23, 2025 08:27 Inactive
@pablomendezroyo pablomendezroyo merged commit 778e8c1 into pablo/allow-setting-starknet-envs Dec 23, 2025
5 of 6 checks passed
@pablomendezroyo pablomendezroyo deleted the marc/get-starknet-envs branch December 23, 2025 09:03
pablomendezroyo added a commit that referenced this pull request Dec 23, 2025
* Set starknet envs from frontend

* fix service name

* print starknetstaking envs (#2335)

* print starknetstaking envs

* fill placeholder with current values

* remove log that could print privkey

* set fullnode to starknet

---------

Co-authored-by: Pablo Mendez <pablo@dappnode.io>

* fix color in dark mode

* fix apply changes button enable

---------

Co-authored-by: Pablo Mendez <pablo@dappnode.io>
Co-authored-by: Marc Font <36164126+Marketen@users.noreply.github.com>
pablomendezroyo added a commit that referenced this pull request Dec 23, 2025
* Add Starknet

* Update Starknet configuration for Sepolia network.
Fix some bugs

* Added docs and fix some bugs

* Add waring if L1 not running

* Remove console logs

* Refactor consensus and mevBoost files for consistency

* Apply Optimism routing pattern to Starknet routes (#2331)

* Initial plan

* Apply Optimism pattern to Starknet in useFilterStakersNetworks

Co-authored-by: pablomendezroyo <41727368+pablomendezroyo@users.noreply.github.com>

* Add support for starknet-sepolia testnet route

Co-authored-by: pablomendezroyo <41727368+pablomendezroyo@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: pablomendezroyo <41727368+pablomendezroyo@users.noreply.github.com>

* starknet as EC/CC (#2332)

* starknet-ec-cc

* starknet exec global envs

* fix types

* signer fix

* staking app

* staking app

* Add Starknet support and configuration updates (#2333)

* Set starknet envs from frontend

* fix service name

* print starknetstaking envs (#2335)

* print starknetstaking envs

* fill placeholder with current values

* remove log that could print privkey

* set fullnode to starknet

---------

Co-authored-by: Pablo Mendez <pablo@dappnode.io>

* fix color in dark mode

* fix apply changes button enable

---------

Co-authored-by: Pablo Mendez <pablo@dappnode.io>
Co-authored-by: Marc Font <36164126+Marketen@users.noreply.github.com>

---------

Co-authored-by: pablomendezroyo <41727368+pablomendezroyo@users.noreply.github.com>
Co-authored-by: hcastc00 <hcastc00@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Marc Font <36164126+Marketen@users.noreply.github.com>
Co-authored-by: Pablo Mendez <pablo@dappnode.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants