Add Starknet by hcastc00 · Pull Request #2322 · dappnode/DNP_DAPPMANAGER

hcastc00 · 2025-12-04T12:10:04Z

Context

Provide context of this PR: why it was created? what does it fixes? what new feature does it provides? ...

Approach

Define the solution for the issue or feature that this PR aims to fix

Test instructions

github-actions · 2025-12-04T12:12:06Z

🚀 Deployed on https://694a5f9d64882630d420adb4--objective-borg-9eeae5.netlify.app

Fix some bugs

Marketen · 2025-12-16T08:45:24Z

packages/stakers/src/mevBoost.ts

-    [Network.Lukso]: db.mevBoostLukso
+    [Network.Lukso]: db.mevBoostLukso,
+    [Network.StarknetMainnet]: { get: () => false, set: async () => {} },
+    [Network.StarknetSepolia]: { get: () => false, set: async () => {} }


why define this in a different way? Can it be done like

[Network.StarknetMainnet]: db.mevBoostStarknetMainnet [Network.StarknetSepolia]: db.mevBoostStarknetMainnet

I know it will probably be always "false", but just for the sake of maintainability

Marketen · 2025-12-16T10:01:16Z

packages/admin-ui/src/__mock-backend__/stakerConfig.ts

+          consensusClients: [],
+          web3Signer: {
+            status: "ok",
+            dnpName: "starknetstaking-sepolia.dnp.dappnode.eth",
+            isInstalled: false,
+            isRunning: false,
+            isUpdated: false,
+            isSelected: false,
+            avatarUrl: "",
+            data: {
+              dnpName: "package",
+              reqVersion: "0.1.0",
+              semVersion: "0.1.0",
+              imageFile: {
+                hash: "QM..",
+                source: "ipfs",
+                size: 123
+              },
+              warnings: {},
+              signedSafe: true,
+              manifest: {
+                name: "starknetstaking-sepolia.dnp.dappnode.eth",
+                description: "Starknet Sepolia Staking Application",
+                shortDescription: "Starknet Sepolia Staking",
+                version: "0.1.0"


why is starknetstaking part of web3signer object?

As starknetstaking packages manages your validator keys I treated it as a signer

Marketen · 2025-12-16T11:06:37Z

packages/types/src/globalEnvs.ts

+  STARKNET_CLIENT_MAINNET: "_DAPPNODE_GLOBAL_STARKNET_CLIENT_MAINNET", // "juno.dnp.dappnode.eth"
+  STARKNET_CLIENT_SEPOLIA: "_DAPPNODE_GLOBAL_STARKNET_CLIENT_SEPOLIA", // "juno-sepolia.dnp.dappnode.eth"


what package use these variables?

None at the moment. Is it best to delete them?

Marketen · 2025-12-16T11:07:25Z

packages/types/src/stakers.ts

+  Pathfinder = "pathfinder.dnp.dappnode.eth"
+}
+export enum SignerStarknetMainnet {
+  Web3signer = "starknetstaking.dnp.dappnode.eth"


do we add keys in starknetstacking dnp package? why treat it as web3signer?

Your validator keys are in the starknetstacking package yep. I treated it as a signer for its similarity

Marketen · 2025-12-16T11:07:33Z

packages/types/src/stakers.ts

+  Pathfinder = "pathfinder-sepolia.dnp.dappnode.eth"
+}
+export enum SignerStarknetSepolia {
+  Web3signer = "starknetstaking-sepolia.dnp.dappnode.eth"


same as above

Marketen · 2025-12-16T11:09:44Z

packages/stakers/src/consensus.ts

    [Network.Lukso]: [
      { dnpName: ConsensusClientLukso.Prysm, minVersion: "0.1.0" },
      { dnpName: ConsensusClientLukso.Teku, minVersion: "0.1.0" }
-    ]
+    ],
+    [Network.StarknetMainnet]: [],
+    [Network.StarknetSepolia]: []


can we have a min version of 0.1.0 like in the other networks when the first version of the package is the first one to be released?

just for maintainability

As Starknet uses fullnodes, I included them in the execution.ts, so empty CC list

Marketen · 2025-12-16T11:10:26Z

packages/stakers/src/execution.ts

      { dnpName: ExecutionClientSepolia.Reth, minVersion: "0.1.0" }
    ],
-    [Network.Lukso]: [{ dnpName: ExecutionClientLukso.Geth, minVersion: "0.1.0" }]
+    [Network.Lukso]: [{ dnpName: ExecutionClientLukso.Geth, minVersion: "0.1.0" }],
+    [Network.StarknetMainnet]: [
+      { dnpName: StarknetClientMainnet.Juno, minVersion: "0.1.0" },
+      { dnpName: StarknetClientMainnet.Pathfinder, minVersion: "0.1.0" }
+    ],
+    [Network.StarknetSepolia]: [
+      { dnpName: StarknetClientSepolia.Juno, minVersion: "0.1.0" },
+      { dnpName: StarknetClientSepolia.Pathfinder, minVersion: "0.1.0" }
+    ]


compatibility is well done here with 0.1.0

Marketen · 2025-12-16T11:14:14Z

packages/admin-ui/src/pages/stakers/components/useStakerConfig.ts

@@ -162,10 +166,17 @@ function getChanges({
    };

  // Not allowed if changes AND (EC or CC are deselected) AND (signer or mev boost)
-  if (!isExecAndConsSelected && (newStakerConfig.web3signerDnpName || newStakerConfig.mevBoostDnpName))
+  // Exception: Starknet networks only need execution client
+  const hasRequiredClients = isStarknetNetwork
+    ? Boolean(newStakerConfig.executionDnpName)
+    : isExecAndConsSelected;
+
+  if (!hasRequiredClients && (newStakerConfig.web3signerDnpName || newStakerConfig.mevBoostDnpName))
    return {
      isAllowed: false,
-      reason: "To enable web3signer and/or MEV boost, execution and consensus clients must be selected",
+      reason: isStarknetNetwork
+        ? "To enable web3signer and/or MEV boost, execution client must be selected"
+        : "To enable web3signer and/or MEV boost, execution and consensus clients must be selected",


this is doable but makes code messy. What do you think @pablomendezroyo ?

Marketen · 2025-12-16T11:18:50Z

packages/admin-ui/src/pages/rollups/components/columns/StarknetSigner.tsx

+import { getInstallerPath } from "pages/installer";
+import { useNavigate } from "react-router-dom";
+
+export default function StarknetSigner({


why is this needed?

Marketen · 2025-12-16T11:19:23Z

packages/admin-ui/src/pages/rollups/components/columns/StarknetFullNode.tsx

+import { getInstallerPath } from "pages/installer";
+import { useNavigate } from "react-router-dom";
+
+export default function StarknetFullNode({


same, why is this needed? can the fullnode of stakers be reused?

Its the component for rendering the different starknet full nodes

Marketen · 2025-12-16T11:23:55Z

packages/admin-ui/src/hooks/useFilterStakersNetworks.ts

-
-const netOf = (r: RouteType): Network | undefined =>
-  isStakerRoute(r) ? (r.element as React.ReactElement).props?.network : undefined;
+const isStakerRoute = (r: RouteType) =>


why is this change needed?

Otherwise, the STARKNET tab is not shown

pablomendezroyo · 2025-12-18T09:38:54Z

packages/admin-ui/src/hooks/useFilterStakersNetworks.ts

 import StakerNetwork from "pages/stakers/components/StakerNetwork";
+import Starknet from "pages/rollups/components/Starknet";

-const isStakerRoute = (r: RouteType) => React.isValidElement(r.element) && r.element.type === StakerNetwork;


@copilot could you make a commit suggestion reverting the code from this file to the original one and implement the same for starknet that whats being done right now for optimism?

currentRoute?.subPath === "optimism" || currentRoute?.subPath === "starknet"

will that make the tab render?

Copilot · 2025-12-18T09:40:01Z

@pablomendezroyo I've opened a new pull request, #2331, to work on those changes. Once the pull request is ready, I'll request review from you.

* Initial plan * Apply Optimism pattern to Starknet in useFilterStakersNetworks Co-authored-by: pablomendezroyo <41727368+pablomendezroyo@users.noreply.github.com> * Add support for starknet-sepolia testnet route Co-authored-by: pablomendezroyo <41727368+pablomendezroyo@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: pablomendezroyo <41727368+pablomendezroyo@users.noreply.github.com>

* starknet-ec-cc * starknet exec global envs * fix types * signer fix * staking app * staking app

* Set starknet envs from frontend * fix service name * print starknetstaking envs (#2335) * print starknetstaking envs * fill placeholder with current values * remove log that could print privkey * set fullnode to starknet --------- Co-authored-by: Pablo Mendez <pablo@dappnode.io> * fix color in dark mode * fix apply changes button enable --------- Co-authored-by: Pablo Mendez <pablo@dappnode.io> Co-authored-by: Marc Font <36164126+Marketen@users.noreply.github.com>

Add Starknet

2fe280b

hcastc00 requested a review from a team as a code owner December 4, 2025 12:10

Merge branch 'develop' into add_starknet

95b8369

github-actions bot temporarily deployed to commit December 10, 2025 11:23 Inactive

Update Starknet configuration for Sepolia network.

54b8ae7

Fix some bugs

github-actions bot temporarily deployed to commit December 10, 2025 16:50 Inactive

Added docs and fix some bugs

9ba0010

github-actions bot temporarily deployed to commit December 11, 2025 14:28 Inactive

Add waring if L1 not running

12c2d14

github-actions bot temporarily deployed to commit December 11, 2025 16:20 Inactive

Remove console logs

0c419ce

github-actions bot temporarily deployed to commit December 11, 2025 16:24 Inactive

Marketen reviewed Dec 16, 2025

View reviewed changes

Refactor consensus and mevBoost files for consistency

40d21d0

github-actions bot temporarily deployed to commit December 16, 2025 12:36 Inactive

pablomendezroyo requested changes Dec 18, 2025

View reviewed changes

Copilot AI mentioned this pull request Dec 18, 2025

Apply Optimism routing pattern to Starknet routes #2331

Merged

Merge branch 'develop' into add_starknet

5464a90

github-actions bot temporarily deployed to commit December 18, 2025 09:41 Inactive

github-actions bot temporarily deployed to commit December 18, 2025 10:37 Inactive

github-actions bot temporarily deployed to commit December 18, 2025 12:18 Inactive

starknet as EC/CC (#2332)

147c800

* starknet-ec-cc * starknet exec global envs * fix types * signer fix * staking app * staking app

github-actions bot temporarily deployed to commit December 18, 2025 14:09 Inactive

pablomendezroyo approved these changes Dec 23, 2025

View reviewed changes

Merge branch 'develop' into add_starknet

52259cd

pablomendezroyo merged commit 342c173 into develop Dec 23, 2025
6 checks passed

pablomendezroyo deleted the add_starknet branch December 23, 2025 09:21

		STARKNET_CLIENT_MAINNET: "_DAPPNODE_GLOBAL_STARKNET_CLIENT_MAINNET", // "juno.dnp.dappnode.eth"
		STARKNET_CLIENT_SEPOLIA: "_DAPPNODE_GLOBAL_STARKNET_CLIENT_SEPOLIA", // "juno-sepolia.dnp.dappnode.eth"

Conversation

hcastc00 commented Dec 4, 2025

Context

Approach

Test instructions

Uh oh!

github-actions bot commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Marketen Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Dec 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Dec 4, 2025 •

edited

Loading

Marketen Dec 16, 2025 •

edited

Loading