Bump actions/checkout from 2.0.0 to 4.1.6#16
Closed
dependabot[bot] wants to merge 1 commit intodbtest1from
Closed
Conversation
Bumps [actions/checkout](https://github.com/actions/checkout) from 2.0.0 to 4.1.6. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v4.1.6) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Author
|
The following labels could not be found: |
Author
|
Superseded by #17. |
danmoseley
pushed a commit
that referenced
this pull request
Apr 26, 2025
* JIT: Introduce `LclVarDsc::lvIsMultiRegDest`
With recent work to expand returned promoted locals into `FIELD_LIST`
the only "whole references" of promoted locals we should see is when
stored from a multi-reg node. This is the only knowledge the backend
should need for correctness purposes, so introduce a bit to track this
property, and switch the backend to check this instead.
The existing `lvIsMultiRegRet` is essentially this + whether the local
is returned. We should be able to remove this, but it is currently used
for some heuristics in old promotion, so keep it around for now.
* JIT: Add some more constant folding in lowering
Add folding for shifts and certain binops that are now getting produced
late due to returned `FIELD_LIST` nodes.
win-arm64 example:
```csharp
[MethodImpl(MethodImplOptions.NoInlining)]
static ValueTask<byte> Foo()
{
return new ValueTask<byte>(123);
}
```
```diff
G_M17084_IG02: ;; offset=0x0008
mov x0, xzr
- mov w1, #1
- mov w2, wzr
- mov w3, dotnet#123
- orr w2, w2, w3, LSL #16
- orr w1, w2, w1, LSL #24
- ;; size=24 bbWeight=1 PerfScore 4.00
+ mov w1, #0x17B0000
+ ;; size=8 bbWeight=1 PerfScore 1.00
```
* Feedback
danmoseley
pushed a commit
that referenced
this pull request
May 29, 2025
Add support using bitwise operations to reconstruct registers passed
into calls from multiple promoted fields. Remove the IR invariant that
`FIELD_LIST` args must always map cleanly to registers; instead, any
`FIELD_LIST` is allowed for register-only arguments before lowering, and
lowering takes care to normalize them into a handled shape.
`fgTryMorphStructArg` is changed to take advantage of this by now
producing `FIELD_LIST` even when a promoted arg does not match the
target ABI. Support in physical promotion will be added in a follow up.
Split arguments are not handled and retain the old IR invariant of
requiring registers and stack slots to make cleanly from `FIELD_LIST`.
win-x64 examples:
```csharp
static void Foo(int x)
{
Use<int?>(x);
Use<int?>(5);
Use<int?>(null);
}
```
```diff
G_M7200_IG02: ;; offset=0x0004
- mov byte ptr [rsp+0x20], 1
- mov dword ptr [rsp+0x24], ecx
- mov rcx, qword ptr [rsp+0x20]
+ mov ecx, ecx
+ shl rcx, 32
+ or rcx, 1
call [Program:Bar(System.Nullable`1[int])]
- mov dword ptr [rsp+0x24], 5
- mov rcx, qword ptr [rsp+0x20]
+ mov rcx, 0x500000001
call [Program:Bar(System.Nullable`1[int])]
- mov byte ptr [rsp+0x20], 0
xor ecx, ecx
- mov dword ptr [rsp+0x24], ecx
- mov rcx, qword ptr [rsp+0x20]
- ;; size=55 bbWeight=1 PerfScore 14.25
+ ;; size=34 bbWeight=1 PerfScore 7.50
G_M7200_IG03:
add rsp, 40
tail.jmp [Program:Bar(System.Nullable`1[int])]
;; size=10 bbWeight=1 PerfScore 2.25
```
```csharp
static void Foo(int x, float y)
{
Use((x, y));
}
```
```diff
G_M42652_IG01: ;; offset=0x0000
- push rax
- ;; size=1 bbWeight=1 PerfScore 1.00
+ ;; size=0 bbWeight=1 PerfScore 0.00
G_M42652_IG02:
- mov dword ptr [rsp], ecx
- vmovss dword ptr [rsp+0x04], xmm1
- mov rcx, qword ptr [rsp]
+ vmovd eax, xmm1
+ shl rax, 32
+ mov ecx, ecx
+ or rcx, rax
;; size=13 bbWeight=1 PerfScore 3.00
G_M42652_IG03:
- add rsp, 8
tail.jmp [Program:Use[System.ValueTuple`2[int,float]](System.ValueTuple`2[int,float])]
```
A win-arm64 example:
```csharp
static void Foo(int[] arr)
{
Use(arr.AsMemory());
}
```
```diff
G_M33990_IG01:
- stp fp, lr, [sp, #-0x20]!
+ stp fp, lr, [sp, #-0x10]!
mov fp, sp
- str xzr, [fp, #0x10] // [V03 tmp2]
- ;; size=12 bbWeight=1 PerfScore 2.50
+ ;; size=8 bbWeight=1 PerfScore 1.50
G_M33990_IG02:
cbz x0, G_M33990_IG04
;; size=4 bbWeight=1 PerfScore 1.00
G_M33990_IG03:
- str x0, [fp, #0x10] // [V07 tmp6]
- str wzr, [fp, #0x18] // [V08 tmp7]
- ldr w0, [x0, #0x08]
- str w0, [fp, #0x1C] // [V09 tmp8]
+ ldr w1, [x0, #0x08]
b G_M33990_IG05
- ;; size=20 bbWeight=0.50 PerfScore 3.50
+ ;; size=8 bbWeight=0.50 PerfScore 2.00
G_M33990_IG04:
- str xzr, [fp, #0x10] // [V07 tmp6]
- str xzr, [fp, #0x18]
- ;; size=8 bbWeight=0.50 PerfScore 1.00
+ mov x0, xzr
+ mov w1, wzr
+ ;; size=8 bbWeight=0.50 PerfScore 0.50
G_M33990_IG05:
- ldp x0, x1, [fp, #0x10] // [V03 tmp2], [V03 tmp2+0x08]
- movz x2, #0xD920 // code for Program:Use[System.Memory`1[int]](System.Memory`1[int])
- movk x2, #0x4590 LSL #16
+ mov w1, w1
+ lsl x1, x1, #32
+ movz x2, #0xD950 // code for Program:Use[System.Memory`1[int]](System.Memory`1[int])
+ movk x2, #0x4592 LSL #16
movk x2, #0x7FFE LSL #32
ldr x2, [x2]
- ;; size=20 bbWeight=1 PerfScore 7.50
+ ;; size=24 bbWeight=1 PerfScore 6.00
G_M33990_IG06:
- ldp fp, lr, [sp], #0x20
+ ldp fp, lr, [sp], #0x10
br x2
;; size=8 bbWeight=1 PerfScore 2.00
-; Total bytes of code: 72
+; Total bytes of code: 60
```
danmoseley
pushed a commit
that referenced
this pull request
Feb 20, 2026
Enable X64's optimization where we clear LCLHEAP via STORE_BLK inserted
in Lower on arm64.
```cs
static void Test128() => Consume(stackalloc char[128]);
```
was:
```asm
stp xzr, xzr, [sp, #-0x10]!
stp xzr, xzr, [sp, #-0xF0]!
stp xzr, xzr, [sp, #0x10]
stp xzr, xzr, [sp, #0x20]
stp xzr, xzr, [sp, #0x30]
stp xzr, xzr, [sp, #0x40]
stp xzr, xzr, [sp, #0x50]
stp xzr, xzr, [sp, #0x60]
stp xzr, xzr, [sp, #0x70]
stp xzr, xzr, [sp, #0x80]
stp xzr, xzr, [sp, #0x90]
stp xzr, xzr, [sp, #0xA0]
stp xzr, xzr, [sp, #0xB0]
stp xzr, xzr, [sp, #0xC0]
stp xzr, xzr, [sp, #0xD0]
stp xzr, xzr, [sp, #0xE0]
```
now:
```asm
movi v16.16b, #0
stp q16, q16, [x0]
stp q16, q16, [x0, #0x20]
stp q16, q16, [x0, #0x40]
stp q16, q16, [x0, #0x60]
stp q16, q16, [x0, #0x80]
stp q16, q16, [x0, #0xA0]
stp q16, q16, [x0, #0xC0]
stp q16, q16, [x0, #0xE0]
```
Also, for larger sizes the previous logic used to emit a slow loop (e.g.
1024 bytes):
```asm
mov w0, #0x400
G_M30953_IG03:
stp xzr, xzr, [sp, #-0x10]!
subs x0, x0, #16
bne G_M30953_IG03
```
Now it will emit a call to `CORINFO_HELP_MEMZERO`
[Benchmarks.](EgorBot/runtime-utils#553)
```cs
using System.Runtime.CompilerServices;
using BenchmarkDotNet.Attributes;
public class Benchmarks
{
[Benchmark] public void Stackalloc64() => Consume(stackalloc byte[64]);
[Benchmark] public void Stackalloc128() => Consume(stackalloc byte[128]);
[Benchmark] public void Stackalloc256() => Consume(stackalloc byte[256]);
[Benchmark] public void Stackalloc512() => Consume(stackalloc byte[512]);
[Benchmark] public void Stackalloc1024() => Consume(stackalloc byte[1024]);
[Benchmark] public void Stackalloc16384() => Consume(stackalloc byte[16384]);
[MethodImpl(MethodImplOptions.NoInlining)]
static void Consume(Span<byte> x){}
}
```
| Method | Toolchain | Mean | Error | Ratio |
|---------------- |------------------------
|-----------:|----------:|------:|
| Stackalloc64 | Main | 3.425 ns | 0.0004 ns | 1.00 |
| Stackalloc64 | PR | 2.559 ns | 0.0008 ns | 0.75 |
| | | | | |
| Stackalloc128 | Main | 3.999 ns | 0.0002 ns | 1.00 |
| Stackalloc128 | PR | 2.404 ns | 0.0003 ns | 0.60 |
| | | | | |
| Stackalloc256 | Main | 5.431 ns | 0.0005 ns | 1.00 |
| Stackalloc256 | PR | 2.754 ns | 0.0003 ns | 0.51 |
| | | | | |
| Stackalloc512 | Main | 12.661 ns | 0.2744 ns | 1.00 |
| Stackalloc512 | PR | 7.423 ns | 0.0008 ns | 0.59 |
| | | | | |
| Stackalloc1024 | Main | 24.958 ns | 0.5326 ns | 1.00 |
| Stackalloc1024 | PR | 14.031 ns | 0.0040 ns | 0.56 |
| | | | | |
| Stackalloc16384 | Main | 374.899 ns | 0.0130 ns | 1.00 |
| Stackalloc16384 | PR | 111.029 ns | 1.2123 ns | 0.30 |
---------
Co-authored-by: Jakob Botsch Nielsen <Jakob.botsch.nielsen@gmail.com>
danmoseley
added a commit
that referenced
this pull request
Feb 28, 2026
- Fix #2: anchor bot-author regex to avoid false matches - Fix #3: remove duplicate who assignment in unresolved threads block - Fix #4: guard totalComments against null reviewThreads - Fix #5: add total_comments to CSV output - Fix #6: remove unused copilotAgent variable - Fix #7: cap screened-out drafts to 10 to reduce JSON bloat - Fix #8: safer empty check after owner-approver intersection - Fix #9: add Discussion Complexity to SKILL.md scoring table (12 dims) - Fix #10: correct rawMax from 20.0 to 20.5 - Fix #11: update example JSON to match actual output structure - Fix #13: rewrite batch-analysis-workflow.md for script-based architecture - Fix #14: remove stale hardcoded owners from runtime-signals.md - Fix #15: align rubric weight table with script's 12 dimensions - Fix #16: fix community framing inconsistency in runtime-signals.md - Fix alignScore: binary (has area label or not) instead of capping at 0.5 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps actions/checkout from 2.0.0 to 4.1.6.
Release notes
Sourced from actions/checkout's releases.
... (truncated)
Changelog
Sourced from actions/checkout's changelog.
... (truncated)
Commits
a5ac7e5Update for 4.1.6 release (#1733)24ed1a3Check platform for extension (#1732)44c2b7aREADME: Suggestuser.emailto be `41898282+github-actions[bot]@users.norepl...8459bc0Bump actions/upload-artifact from 2 to 4 (#1695)3f603f6Bump actions/setup-node from 1 to 4 (#1696)fd084cdBump github/codeql-action from 2 to 3 (#1694)9c1e94eUpdate NPM dependencies (#1703)0ad4b8fPrep Release v4.1.4 (#1704)43045aeDisableextensions.worktreeConfigwhen disablingsparse-checkout(#1692)37b0821Bump the minor-actions-dependencies group with 2 updates (#1693)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)