Skip to content

Simplified locking for I/O channels in the debugger interface and elsewhere#7

Merged
xavierleroy merged 0 commit intodamiendoligez:fix-bytecode-debuggerfrom
xavierleroy:fix-bytecode-debugger
Jul 1, 2022
Merged

Simplified locking for I/O channels in the debugger interface and elsewhere#7
xavierleroy merged 0 commit intodamiendoligez:fix-bytecode-debuggerfrom
xavierleroy:fix-bytecode-debugger

Conversation

@xavierleroy
Copy link
Copy Markdown

See the two commit messages for explanations.

@damiendoligez
Copy link
Copy Markdown
Owner

This is a nice simplification, but it changes the API for using channels from C, right? Can we estimate the impact on user code ?

@xavierleroy
Copy link
Copy Markdown
Author

it changes the API for using channels from C, right?

You can still Lock and Unlock your channels from C like you must do in 4.12 - 4.14 (if I'm not mistaken), but you can also elect not to Lock and Unlock provided the channel is used in a single-threaded manner, like you used to do in 4.11 and before. So, backward compatibility is improved !

@xavierleroy
Copy link
Copy Markdown
Author

PS. Can you please review ocaml#11356 instead of this PR ?

@xavierleroy xavierleroy force-pushed the fix-bytecode-debugger branch from 51c6eae to 2e4e8a7 Compare July 1, 2022 07:19
@xavierleroy xavierleroy merged commit 2e4e8a7 into damiendoligez:fix-bytecode-debugger Jul 1, 2022
@xavierleroy xavierleroy force-pushed the fix-bytecode-debugger branch from 3b34535 to 10dcb5f Compare July 1, 2022 07:30
@xavierleroy xavierleroy deleted the fix-bytecode-debugger branch July 1, 2022 07:31
damiendoligez pushed a commit that referenced this pull request Sep 12, 2022
- Don't put channels opened from C on this list, only those opened from OCaml
  and tracked by the GC.
- Simplify several functions accordingly.
- Fix an error in caml_finalize_channel where the channel could be
  unlinked from the list, then not freed because not flushed.
damiendoligez pushed a commit that referenced this pull request Oct 11, 2024
…l#13294)

The toplevel printer detects cycles by keeping a hashtable of values
that it has already traversed.

However, some OCaml runtime types (at least bigarrays) may be
partially uninitialized, and hashing them at arbitrary program points
may read uninitialized memory. In particular, the OCaml testsuite
fails when running with a memory-sanitizer enabled, as bigarray
printing results in reads to uninitialized memory:

```
==133712==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x4e6d11 in caml_ba_hash /var/home/edwin/git/ocaml/runtime/bigarray.c:486:45
    #1 0x52474a in caml_hash /var/home/edwin/git/ocaml/runtime/hash.c:251:35
    #2 0x599ebf in caml_interprete /var/home/edwin/git/ocaml/runtime/interp.c:1065:14
    #3 0x5a909a in caml_main /var/home/edwin/git/ocaml/runtime/startup_byt.c:575:9
    #4 0x540ccb in main /var/home/edwin/git/ocaml/runtime/main.c:37:3
    #5 0x7f0910abb087 in __libc_start_call_main (/lib64/libc.so.6+0x2a087) (BuildId: 8f53abaad945a669f2bdcd25f471d80e077568ef)
    #6 0x7f0910abb14a in __libc_start_main@GLIBC_2.2.5 (/lib64/libc.so.6+0x2a14a) (BuildId: 8f53abaad945a669f2bdcd25f471d80e077568ef)
    #7 0x441804 in _start (/var/home/edwin/git/ocaml/runtime/ocamlrun+0x441804) (BuildId: 7a60eef57e1c2baf770bc38d10d6c227e60ead37)

  Uninitialized value was created by a heap allocation
    #0 0x47d306 in malloc (/var/home/edwin/git/ocaml/runtime/ocamlrun+0x47d306) (BuildId: 7a60eef57e1c2baf770bc38d10d6c227e60ead37)
    #1 0x4e7960 in caml_ba_alloc /var/home/edwin/git/ocaml/runtime/bigarray.c:246:12
    #2 0x4e801f in caml_ba_create /var/home/edwin/git/ocaml/runtime/bigarray.c:673:10
    #3 0x59b8fc in caml_interprete /var/home/edwin/git/ocaml/runtime/interp.c:1058:14
    #4 0x5a909a in caml_main /var/home/edwin/git/ocaml/runtime/startup_byt.c:575:9
    #5 0x540ccb in main /var/home/edwin/git/ocaml/runtime/main.c:37:3
    #6 0x7f0910abb087 in __libc_start_call_main (/lib64/libc.so.6+0x2a087) (BuildId: 8f53abaad945a669f2bdcd25f471d80e077568ef)
    #7 0x7f0910abb14a in __libc_start_main@GLIBC_2.2.5 (/lib64/libc.so.6+0x2a14a) (BuildId: 8f53abaad945a669f2bdcd25f471d80e077568ef)
    ocaml#8 0x441804 in _start (/var/home/edwin/git/ocaml/runtime/ocamlrun+0x441804) (BuildId: 7a60eef57e1c2baf770bc38d10d6c227e60ead37)

SUMMARY: MemorySanitizer: use-of-uninitialized-value /var/home/edwin/git/ocaml/runtime/bigarray.c:486:45 in caml_ba_hash
```

The only use of hashing in genprintval is to avoid cycles, that is, it
is only useful for OCaml values that contain other OCaml values
(including possibly themselves). Bigarrays cannot introduce cycles,
and they are always printed as "<abstr>" anyway.

The present commit proposes to be more conservative in which values
are hashed by the cycle detector to avoid this issue: we skip hashing
any value with tag above No_scan_tag -- which may not contain any
OCaml values.

Suggested-by: Gabriel Scherer <gabriel.scherer@gmail.com>

Signed-off-by: Edwin Török <edwin.torok@cloud.com>
Co-authored-by: Edwin Török <edwin.torok@cloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants