tests/*.py: support Python 2 again while preferring Python 3#7940
Closed
mback2k wants to merge 1 commit intocurl:masterfrom
Closed
tests/*.py: support Python 2 again while preferring Python 3#7940mback2k wants to merge 1 commit intocurl:masterfrom
mback2k wants to merge 1 commit intocurl:masterfrom
Conversation
f6e0a34 to
9bd8213
Compare
Member
|
Is this really worth the struggle? Isn't it better to make sure we just skip the tests that need python3 if that isn't available? |
Member
|
On 6 Dec 2021, at 16:51, Daniel Stenberg ***@***.***> wrote:
Is this really worth the struggle? Isn't it better to make sure we just skip the tests that need python3 if that isn't available?
If we can enumerate the affected environments it might be easier to judge?
|
Member
Author
|
All the Windows builds on Azure and Cirrus CIs are affected. |
7a8ae4f to
b35fcd7
Compare
f378dcc to
ccddfae
Compare
c62e583 to
9924e14
Compare
Member
Author
Not actually correct, at least the msys2-based builds already support Python 3. Therefore closing this in favor of #8544. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it possible to use the Python-based test servers
again in legacy environments which do not have modern Python.
Follow up to #7602 which broke Python 2 support
Follow up to #7935 which fixed impacket support