tests/smbserver.py: fix compatibility with impacket 0.9.23+#7935
Closed
mback2k wants to merge 1 commit intocurl:masterfrom
Closed
tests/smbserver.py: fix compatibility with impacket 0.9.23+#7935mback2k wants to merge 1 commit intocurl:masterfrom
mback2k wants to merge 1 commit intocurl:masterfrom
Conversation
impacket now performs sanity checks if the requested and to be served file path actually is inside the real share path. Ref: fortra/impacket#1066 Fixes curl#7924
bdbbd1a to
6eea6a7
Compare
Member
Author
|
Yay, this fixes the two FreeBSD CI builds. If all the other CIs do not show new errors with test 1451 this can be merged. |
bagder
approved these changes
Nov 1, 2021
Member
bagder
left a comment
There was a problem hiding this comment.
I don't know python but if this fixes the problem and works elsewhere then I'm 👍
Member
Author
|
Completely green, merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
impacket now performs sanity checks if the requested and to
be served file path actually is inside the real share path.
Ref: fortra/impacket#1066
Fixes #7924