CI: align test flags in various config files#7690
Closed
mback2k wants to merge 1 commit intocurl:masterfrom
Closed
CI: align test flags in various config files#7690mback2k wants to merge 1 commit intocurl:masterfrom
mback2k wants to merge 1 commit intocurl:masterfrom
Conversation
1. Remove redundant parameters -a -p from target test-nonflaky. 2. Disable testing of SCP protocol on native Windows environments. 3. Use Makefile target to run tests in autotools builds on AppVeyor. 4. Don't use -vc parameter which is reserved for debugging. Replaces curl#7591
Member
Author
|
The zuul CI failure is unrelated to this PR as those CI files aren't touched. |
bagder
reviewed
Sep 23, 2021
Member
bagder
left a comment
There was a problem hiding this comment.
I'm not sure I see the benefit of this, but if you think it makes things better go for it.
I think maybe added conditional check for appveyor is a bit hidden here while probably being the larger actual change!
| env: | ||
| AZURE_ACCESS_TOKEN: "$(System.AccessToken)" | ||
| TFLAGS: "-u -vc /usr/bin/curl.exe -r -rm $(tests)" | ||
| TFLAGS: "-r -rm -u !SCP $(tests)" |
Member
There was a problem hiding this comment.
Does anyone ever read the -r generated output? I know I never do it.
Member
Author
There was a problem hiding this comment.
I do sometimes as one way to figure out potential reasons for test flakiness and timeouts.
mback2k
added a commit
to mback2k/curl
that referenced
this pull request
Sep 27, 2021
Make it easy to use the same set of test flags throughout all current and future CI builds. Follow up to curl#7690
mback2k
added a commit
that referenced
this pull request
Dec 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #7591
--
The other things mentioned in #7591 will be done separately.