Skip to content

configure: do not set -Wformat=2 for mingw debug builds#6082

Closed
bagder wants to merge 3 commits intomasterfrom
bagder/configure-format-mingw
Closed

configure: do not set -Wformat=2 for mingw debug builds#6082
bagder wants to merge 3 commits intomasterfrom
bagder/configure-format-mingw

Conversation

@bagder
Copy link
Copy Markdown
Member

@bagder bagder commented Oct 14, 2020

With GCC 10 (at least) on mingw, we get false positive warnings
when using this option. Never use it for mingw.

Fixes #6079

@bagder bagder added the build label Oct 14, 2020
@MarcelRaad
Copy link
Copy Markdown
Member

MarcelRaad commented Oct 15, 2020

As this is a bug specific to GCC 10, I'd rather at least leave it on on older versions, wouldn't you?
Also, for the record, an alternative would be to disable -pedantic as the -Wpedantic-ms-format warning is a combination of those two.

MarcelRaad
MarcelRaad reviewed Oct 15, 2020
View reviewed changes
@MarcelRaad
Copy link
Copy Markdown
Member

MarcelRaad commented Oct 15, 2020

Or can we maybe do that only for that one file where the specific warning cannot be disabled?

@bagder
Copy link
Copy Markdown
Member Author

bagder commented Oct 15, 2020

Let me try that...

bagder added 3 commits October 15, 2020 10:12
@bagder
configure: do not set -Wformat=2 for mingw debug builds
834bd7f 
With GCC 10 (at least) on mingw, we get false positive warnings
when using this option. Never use it for mingw.

Fixes #6079
@bagder
Revert "configure: do not set -Wformat=2 for mingw debug builds"
bea3c8c 
This reverts commit 834bd7f.
@bagder
src/tool_filetime: disable -Wformat on mingw for this file
e2af803 
Fixes #6079
@bagder bagder force-pushed the bagder/configure-format-mingw branch from 462b357 to e2af803 Compare October 15, 2020 08:17
@bagder
Copy link
Copy Markdown
Member Author

bagder commented Oct 15, 2020

Seems to work. Now we're back to our regular set of flaky test results... 😞

@bagder bagder closed this in 7c88fe3 Oct 15, 2020
@mback2k
Copy link
Copy Markdown
Member

mback2k commented Oct 15, 2020 •
edited
Loading

Seems to work.

Great!

Now we're back to our regular set of flaky test results... 😞

Which I am hardly trying to solve... 🧑‍🏭

@bagder bagder deleted the bagder/configure-format-mingw branch December 22, 2020 12:53
mback2k added a commit to mback2k/curl that referenced this pull request Dec 13, 2021
@mback2k
CI: build examples for additional code verification
8c81ead 
Some CIs already build them, let's do it on more of them.

Ignore -Wformat while using GCC on mingw to compile examples.
Improve size_t to long conversion in imap-append.c example.

Ref: curl#6079
Ref: curl#6082
Assisted-by: Jay Satiro

Follow up to curl#7690
Replaces curl#7591
Closes curl#7922
mback2k added a commit that referenced this pull request Dec 14, 2021
@mback2k
docs/examples: workaround broken -Wno-pedantic-ms-format
77311f4 
Avoid CURL_FORMAT_CURL_OFF_T by using unsigned long instead.
Improve size_t to long conversion in imap-append.c example.

Ref: #6079
Ref: #6082
Assisted-by: Jay Satiro
Reviewed-by: Daniel Stenberg

Preparation of #7922
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MarcelRaad MarcelRaad MarcelRaad left review comments

Assignees

No one assigned

Labels

build

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Azure DevOps shows GCC 10 compilation errors due to type mismatch between curl_off_t typeof and format

3 participants

@bagder @MarcelRaad @mback2k