cmake: drop two stray TLS feature checks for wolfSSL#16339
Closed
vszakats wants to merge 2 commits intocurl:masterfrom
Closed
cmake: drop two stray TLS feature checks for wolfSSL#16339vszakats wants to merge 2 commits intocurl:masterfrom
vszakats wants to merge 2 commits intocurl:masterfrom
Conversation
TLS-SRP isn't implemented for wolfSSL in libcurl. If it gets implemented, the feature check should use a separate macro than OpenSSL, it should check for the wolfssl-prefix API and a matching check should be added to `./configure`.
SSL_set0_wbio, SSL_CTX_set_srp_username feature checks for wolfSSL
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
Drop check for `SSL_set0_wbio`, `SSL_CTX_set_srp_username`. The wolfSSL backend doesn't implement these features. The checks were wrong, and also missing from `./configure`. If they get implemented, the feature checks should use distinct macros from OpenSSL; they should check for the `wolfSSL_`-prefixed APIs via wolfSSL headers; and matching checks should be added to `./configure`. Follow-up to 781242f curl#11967 curl#11964 Closes curl#16339
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop check for
SSL_set0_wbio,SSL_CTX_set_srp_username.The wolfSSL backend doesn't implement these features. The checks were
wrong, and also missing from
./configure.If they get implemented, the feature checks should use distinct macros
from OpenSSL; they should check for the
wolfSSL_-prefixed APIs viawolfSSL headers; and matching checks should be added to
./configure.Follow-up to 781242f #11967 #11964