cmake: detect TLS-SRP in OpenSSL/wolfSSL/GnuTLS#11967
Closed
vszakats wants to merge 5 commits intocurl:masterfrom
Closed
cmake: detect TLS-SRP in OpenSSL/wolfSSL/GnuTLS#11967vszakats wants to merge 5 commits intocurl:masterfrom
vszakats wants to merge 5 commits intocurl:masterfrom
Conversation
16 tasks
Member
Author
|
This should probably be a 'found', if this OpenSSL 1.0.2 has SRP enabled: https://ci.appveyor.com/project/curlorg/curl/builds/48139282/job/7xbgl6gw8u7a17fy#L33. Error: I won't be dealing with this, it's an obsolete OpenSSL version combined with MSVC. UPDATE: Upgrading to OpenSSL 1.1.1 fixes it. |
With new option `CURL_DISABLE_SRP=ON` to force-disable it. To match existing similar option and detection logic in autotools. Also: - fix detecting GnuTLS. - comment typos, whitespace. Ref: curl#11964 Closes #xxxxx
This could use a more delicate approach.
6df79e6 to
f4d54a8
Compare
vszakats
added a commit
to curl/curl-for-win
that referenced
this pull request
Sep 28, 2023
CMake did not detect TLS-SRP support and did not enable it automatically in curl 8.3.0 and earlier. This might change and we want to keep it disabled in curl-for-win. Ref: curl/curl#11967
vszakats
added a commit
to curl/curl-for-win
that referenced
this pull request
Sep 28, 2023
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Jul 27, 2024
`nettle` is a direct dependency of curl, when building with GnuTLS. Detect it as such. Follow-up to 781242f curl#11967 Closes #xxxxx
vszakats
added a commit
that referenced
this pull request
Feb 15, 2025
Drop check for `SSL_set0_wbio`, `SSL_CTX_set_srp_username`. The wolfSSL backend doesn't implement these features. The checks were wrong, and also missing from `./configure`. If they get implemented, the feature checks should use distinct macros from OpenSSL; they should check for the `wolfSSL_`-prefixed APIs via wolfSSL headers; and matching checks should be added to `./configure`. Follow-up to 781242f #11967 #11964 Closes #16339
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
Drop check for `SSL_set0_wbio`, `SSL_CTX_set_srp_username`. The wolfSSL backend doesn't implement these features. The checks were wrong, and also missing from `./configure`. If they get implemented, the feature checks should use distinct macros from OpenSSL; they should check for the `wolfSSL_`-prefixed APIs via wolfSSL headers; and matching checks should be added to `./configure`. Follow-up to 781242f curl#11967 curl#11964 Closes curl#16339
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With new option
CURL_DISABLE_SRP=ONto force-disable it.To match existing option and detection logic in autotools.
Also:
We assume
nettleas a GnuTLS dependency.TLS-SRP fails to detect with 1.0.2 due to an OpenSSL header bug.
Ref: #11964
Closes #11967